starred/PHP-DNS-SERVER
1
0
Fork 0
mirror of https://github.com/yswery/PHP-DNS-SERVER.git synced 2026-04-26 09:45:54 +03:00
Code Issues 6 Projects Releases 4 Packages Wiki Activity

[PR #62] [MERGED] Feature/version 1 additions #78

New issue
Closed
opened 2026-03-04 23:24:12 +03:00 by kerem · 0 comments
kerem commented 2026-03-04 23:24:12 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/62
Author: @ivanstan
Created: 9/11/2018
Status: ✅ Merged
Merged: 9/13/2018
Merged by: @samuelwilliams

Base: version-1 ← Head: feature/version-1-additions

📝 Commits (10+)

  • 477990d Resolved issues in Server class reported by phpstorm
  • 77f6c13 Resolved issues in JsonResolverTest and JsonResolver class reported by
  • ca04d3e Resolved issues in ClassEnum class reported by
  • ee53104 Resolved issues in Decoder class reported by
  • 5973549 Resolved issues in Encoder class reported by
  • ae311ac Resolved issues in Message class reported by
  • 86d69a9 Resolved issues in RecordTypeEnum class reported by
  • a20de87 Resolved issues in RecursiveResolver class reported by
  • 6a561dd Resolved issues in ResourceRecord class reported by
  • 12e44f7 Resolved issues in ResourceRecord class reported by

📊 Changes

13 files changed (+181 additions, -196 deletions)

View changed files

📝 README.md (+1 -3)
📝 src/ClassEnum.php (+5 -5)
📝 src/Decoder.php (+19 -19)
📝 src/Encoder.php (+23 -21)
📝 src/JsonResolver.php (+28 -30)
📝 src/Message.php (+8 -8)
📝 src/RecordTypeEnum.php (+47 -47)
📝 src/RecursiveResolver.php (+11 -12)
📝 src/ResourceRecord.php (+13 -13)
📝 src/Server.php (+15 -27)
📝 src/Tests/JsonResolverTest.php (+5 -5)
📝 src/Tests/RecordTypeEnumTest.php (+5 -5)
📝 src/Tests/ServerTest.php (+1 -1)

📄 Description

I basically went trough classes and resolved whatever phpstorm inspections reported

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/62 **Author:** [@ivanstan](https://github.com/ivanstan) **Created:** 9/11/2018 **Status:** ✅ Merged **Merged:** 9/13/2018 **Merged by:** [@samuelwilliams](https://github.com/samuelwilliams) **Base:** `version-1` ← **Head:** `feature/version-1-additions` --- ### 📝 Commits (10+) - [`477990d`](https://github.com/yswery/PHP-DNS-SERVER/commit/477990d5a94073be6f12a8aaac87e639b4f6fa30) Resolved issues in Server class reported by phpstorm - [`77f6c13`](https://github.com/yswery/PHP-DNS-SERVER/commit/77f6c135008e2c4dcc96abe9125a2f8458c2aed0) Resolved issues in JsonResolverTest and JsonResolver class reported by - [`ca04d3e`](https://github.com/yswery/PHP-DNS-SERVER/commit/ca04d3eadc988812b2bdf25a33896360a99b7cd1) Resolved issues in ClassEnum class reported by - [`ee53104`](https://github.com/yswery/PHP-DNS-SERVER/commit/ee531047c616550294831a1d031806b0e5824c61) Resolved issues in Decoder class reported by - [`5973549`](https://github.com/yswery/PHP-DNS-SERVER/commit/597354952eb84abb821f17bf589fcc9e2f9e657a) Resolved issues in Encoder class reported by - [`ae311ac`](https://github.com/yswery/PHP-DNS-SERVER/commit/ae311acfb2156991586c6115c96a9a5e2bfc4f14) Resolved issues in Message class reported by - [`86d69a9`](https://github.com/yswery/PHP-DNS-SERVER/commit/86d69a9e08d2037cfe0b12449e67a4d5f7f8f3a2) Resolved issues in RecordTypeEnum class reported by - [`a20de87`](https://github.com/yswery/PHP-DNS-SERVER/commit/a20de87be76d99f082b4f515cd288e2d36ca1daa) Resolved issues in RecursiveResolver class reported by - [`6a561dd`](https://github.com/yswery/PHP-DNS-SERVER/commit/6a561ddac5f20b1d1caccb3ece99fff3026cb304) Resolved issues in ResourceRecord class reported by - [`12e44f7`](https://github.com/yswery/PHP-DNS-SERVER/commit/12e44f7d7a2eb8035983d73eb9c62039eeadaf37) Resolved issues in ResourceRecord class reported by ### 📊 Changes **13 files changed** (+181 additions, -196 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -3) 📝 `src/ClassEnum.php` (+5 -5) 📝 `src/Decoder.php` (+19 -19) 📝 `src/Encoder.php` (+23 -21) 📝 `src/JsonResolver.php` (+28 -30) 📝 `src/Message.php` (+8 -8) 📝 `src/RecordTypeEnum.php` (+47 -47) 📝 `src/RecursiveResolver.php` (+11 -12) 📝 `src/ResourceRecord.php` (+13 -13) 📝 `src/Server.php` (+15 -27) 📝 `src/Tests/JsonResolverTest.php` (+5 -5) 📝 `src/Tests/RecordTypeEnumTest.php` (+5 -5) 📝 `src/Tests/ServerTest.php` (+1 -1) </details> ### 📄 Description I basically went trough classes and resolved whatever phpstorm inspections reported --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 23:24:12 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
v1.4.1
v1.4
v1.3
v1.2
v1.1.3
v1.1.2
V1.1.1
v1.1
v1.0.1
v1.0
v0.3
v0.2
v0.1
Labels
Clear labels   
bug

   
enhancement

   
enhancement

   
hacktoberfest

   
pull-request

Mirrored from GitHub Pull Request

  
question
No labels
bug
enhancement
enhancement
hacktoberfest
pull-request
question
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/PHP-DNS-SERVER#78
No description provided.