[PR #59] [CLOSED] fixes phpunit tests and support for yaml configurations #75

New issue

Closed

opened 2026-03-04 23:24:11 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 23:24:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/59
Author: @ivanstan
Created: 9/10/2018
Status: ❌ Closed

Base: master ← Head: feature/yaml-resolver

📝 Commits (4)

527c657 fixes phpunit tests and support for yaml configurations
161c052 updated phpunit version
160afd6 changed phpunit version, removed travis for php 5.6
6e77ceb updated php-code-coverage

📊 Changes

9 files changed (+72 additions, -23 deletions)

View changed files

📝 .travis.yml (+0 -1)
📝 composer.json (+3 -3)
📝 src/JsonResolver.php (+5 -5)
➕ src/YamlResolver.php (+15 -0)
📝 tests/JsonResolverTest.php (+12 -9)
📝 tests/RecordTypeEnumTest.php (+7 -2)
📝 tests/ServerTest.php (+4 -3)
➕ tests/YamlResolverTest.php (+13 -0)
➕ tests/test_records.yaml (+13 -0)

📄 Description

For my taste yaml files are more suitable to hold dns records, so I made this YamlResolver that extends JsonResolver

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/59 **Author:** [@ivanstan](https://github.com/ivanstan) **Created:** 9/10/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `feature/yaml-resolver` --- ### 📝 Commits (4) - [`527c657`](https://github.com/yswery/PHP-DNS-SERVER/commit/527c657b58c74d8e8d9c2f5e3bf24749d42aa1b1) fixes phpunit tests and support for yaml configurations - [`161c052`](https://github.com/yswery/PHP-DNS-SERVER/commit/161c05281aceeeca09ae2030d907cd06347c1ed8) updated phpunit version - [`160afd6`](https://github.com/yswery/PHP-DNS-SERVER/commit/160afd6f5cdb71741cf077360a68b2c55d288b63) changed phpunit version, removed travis for php 5.6 - [`6e77ceb`](https://github.com/yswery/PHP-DNS-SERVER/commit/6e77ceb8bc6a9fd28414ad6774ccec5502da04a0) updated php-code-coverage ### 📊 Changes **9 files changed** (+72 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+0 -1) 📝 `composer.json` (+3 -3) 📝 `src/JsonResolver.php` (+5 -5) ➕ `src/YamlResolver.php` (+15 -0) 📝 `tests/JsonResolverTest.php` (+12 -9) 📝 `tests/RecordTypeEnumTest.php` (+7 -2) 📝 `tests/ServerTest.php` (+4 -3) ➕ `tests/YamlResolverTest.php` (+13 -0) ➕ `tests/test_records.yaml` (+13 -0) </details> ### 📄 Description For my taste yaml files are more suitable to hold dns records, so I made this YamlResolver that extends JsonResolver --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>