[PR #55] [MERGED] Server tests #72

New issue

Closed

opened 2026-03-04 23:24:10 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 23:24:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/55
Author: @samuelwilliams
Created: 9/7/2018
Status: ✅ Merged
Merged: 9/8/2018
Merged by: @samuelwilliams

Base: master ← Head: ServerTests

📝 Commits (10+)

e38e3a9 More tests on Server class.
fbcbacb Wrote test for ds_encode_type()
48fe397 Simplified TestServerProxy. Catch the ds_errorbefore dying.
cc20d5f Removed redundant if loop.
cc9edf3 Tests for ds_encode_type()
1314de1 Type hinting the constructor.
c8add1c Added more tests.
3340231 Fixed type decoding for MX records.
fc918fd New test for ds_encode_rr().
85b80e9 Correctly validate an IP address in ds_encode_type()

📊 Changes

5 files changed (+297 additions, -42 deletions)

View changed files

📝 .travis.yml (+0 -1)
📝 composer.json (+2 -2)
📝 src/Server.php (+18 -20)
📝 tests/ServerTest.php (+259 -4)
📝 tests/TestServerProxy.php (+18 -15)

📄 Description

Significantly expanded ServerTests. Some small improvements made to the Server class as a result. The requirements in composer and travis have been updated to remove PHP 5.5. This leaves the project on much stronger ground to implement future changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/55 **Author:** [@samuelwilliams](https://github.com/samuelwilliams) **Created:** 9/7/2018 **Status:** ✅ Merged **Merged:** 9/8/2018 **Merged by:** [@samuelwilliams](https://github.com/samuelwilliams) **Base:** `master` ← **Head:** `ServerTests` --- ### 📝 Commits (10+) - [`e38e3a9`](https://github.com/yswery/PHP-DNS-SERVER/commit/e38e3a9746cd653e90640abc12fe26794ea97d2b) More tests on Server class. - [`fbcbacb`](https://github.com/yswery/PHP-DNS-SERVER/commit/fbcbacbe8341343acbbc4741743eef425f8b2228) Wrote test for ds_encode_type() - [`48fe397`](https://github.com/yswery/PHP-DNS-SERVER/commit/48fe3972ebd411761c204ae04c43c4f19214c3de) Simplified TestServerProxy. Catch the ds_errorbefore dying. - [`cc20d5f`](https://github.com/yswery/PHP-DNS-SERVER/commit/cc20d5fed4dbe52c10786ca905f4efdeac2aeda5) Removed redundant if loop. - [`cc9edf3`](https://github.com/yswery/PHP-DNS-SERVER/commit/cc9edf34ce37b8222589d69aac26b514f023a351) Tests for ds_encode_type() - [`1314de1`](https://github.com/yswery/PHP-DNS-SERVER/commit/1314de1751396210d1379844cc9b2a2c55d5f2ef) Type hinting the constructor. - [`c8add1c`](https://github.com/yswery/PHP-DNS-SERVER/commit/c8add1c0d6ce4e64bce08fc63110ed55341b8bb6) Added more tests. - [`3340231`](https://github.com/yswery/PHP-DNS-SERVER/commit/3340231da3c9644f30eeeaa74de8aabff85dcffe) Fixed type decoding for MX records. - [`fc918fd`](https://github.com/yswery/PHP-DNS-SERVER/commit/fc918fdccd1fcbaf7d112a9723679f20b12f5f66) New test for ds_encode_rr(). - [`85b80e9`](https://github.com/yswery/PHP-DNS-SERVER/commit/85b80e90e05460f17c03f8bbdcf2685941177f26) Correctly validate an IP address in ds_encode_type() ### 📊 Changes **5 files changed** (+297 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+0 -1) 📝 `composer.json` (+2 -2) 📝 `src/Server.php` (+18 -20) 📝 `tests/ServerTest.php` (+259 -4) 📝 `tests/TestServerProxy.php` (+18 -15) </details> ### 📄 Description Significantly expanded ServerTests. Some small improvements made to the Server class as a result. The requirements in composer and travis have been updated to remove PHP 5.5. This leaves the project on much stronger ground to implement future changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>