[PR #28] [MERGED] Fixes crash when querying for '.' #57

New issue

Closed

opened 2026-03-04 23:24:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 23:24:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/28
Author: @nkakouros
Created: 8/4/2017
Status: ✅ Merged
Merged: 8/7/2017
Merged by: @yswery

Base: master ← Head: trace

📝 Commits (2)

cd9f786 Removes unnecessary trim
a6181fb Updates travis ubuntu

📊 Changes

2 files changed (+4 additions, -1 deletions)

View changed files

📝 .travis.yml (+1 -0)
📝 src/RecursiveProvider.php (+3 -1)

📄 Description

There was an unecessary trim($...question, '.') that when the query was simlpy '.', returned an empty string. This caused the RecursiveProvider to crash when calling php's get_dns_record with an empty domain name.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/28 **Author:** [@nkakouros](https://github.com/nkakouros) **Created:** 8/4/2017 **Status:** ✅ Merged **Merged:** 8/7/2017 **Merged by:** [@yswery](https://github.com/yswery) **Base:** `master` ← **Head:** `trace` --- ### 📝 Commits (2) - [`cd9f786`](https://github.com/yswery/PHP-DNS-SERVER/commit/cd9f7860716d6c894b0ab9e6840215c0c9451d11) Removes unnecessary trim - [`a6181fb`](https://github.com/yswery/PHP-DNS-SERVER/commit/a6181fbe8ec5f326bda4e2ca44dc4c2308e355f2) Updates travis ubuntu ### 📊 Changes **2 files changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -0) 📝 `src/RecursiveProvider.php` (+3 -1) </details> ### 📄 Description There was an unecessary trim($...question, '.') that when the query was simlpy '.', returned an empty string. This caused the RecursiveProvider to crash when calling php's get_dns_record with an empty domain name. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>