[PR #19] [MERGED] Coding Standards #52

New issue

Closed

opened 2026-03-04 23:24:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 23:24:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/19
Author: @samuelwilliams
Created: 4/8/2017
Status: ✅ Merged
Merged: 4/9/2017
Merged by: @yswery

Base: master ← Head: master

📝 Commits (4)

1a240d7 Code clean-up
1a60730 CS fix
5f245ce Added all record types to the enum.
d6e82b3 Added types to enum test.

📊 Changes

8 files changed (+533 additions, -456 deletions)

View changed files

📝 example.php (+1 -1)
📝 src/AbstractStorageProvider.php (+3 -4)
📝 src/JsonStorageProvider.php (+9 -10)
📝 src/RecordTypeEnum.php (+70 -10)
📝 src/RecursiveProvider.php (+18 -20)
📝 src/Server.php (+398 -406)
📝 src/StackableResolver.php (+4 -4)
📝 tests/RecordTypeEnumTest.php (+30 -1)

📄 Description

I ran the PHP-CS-Fixer over the code base as well as removed some code duplication.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/19 **Author:** [@samuelwilliams](https://github.com/samuelwilliams) **Created:** 4/8/2017 **Status:** ✅ Merged **Merged:** 4/9/2017 **Merged by:** [@yswery](https://github.com/yswery) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`1a240d7`](https://github.com/yswery/PHP-DNS-SERVER/commit/1a240d7f665e20e50fc74a04a8af354934fd2d0d) Code clean-up - [`1a60730`](https://github.com/yswery/PHP-DNS-SERVER/commit/1a607308fa56c3d0a17fd736d9844f0802a9a12a) CS fix - [`5f245ce`](https://github.com/yswery/PHP-DNS-SERVER/commit/5f245cebb2611f1ea34cf6e7def55e70d383172c) Added all record types to the enum. - [`d6e82b3`](https://github.com/yswery/PHP-DNS-SERVER/commit/d6e82b3607e5f0d392dca68c7bce5b723fac3cc6) Added types to enum test. ### 📊 Changes **8 files changed** (+533 additions, -456 deletions) <details> <summary>View changed files</summary> 📝 `example.php` (+1 -1) 📝 `src/AbstractStorageProvider.php` (+3 -4) 📝 `src/JsonStorageProvider.php` (+9 -10) 📝 `src/RecordTypeEnum.php` (+70 -10) 📝 `src/RecursiveProvider.php` (+18 -20) 📝 `src/Server.php` (+398 -406) 📝 `src/StackableResolver.php` (+4 -4) 📝 `tests/RecordTypeEnumTest.php` (+30 -1) </details> ### 📄 Description I ran the PHP-CS-Fixer over the code base as well as removed some code duplication. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>