[PR #21] [MERGED] Json storage #50

New issue

Closed

opened 2026-03-04 23:24:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 23:24:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/yswery/PHP-DNS-SERVER/pull/21
Author: @samuelwilliams
Created: 4/11/2017
Status: ✅ Merged
Merged: 4/14/2017
Merged by: @yswery

Base: master ← Head: JSON_Storage

📝 Commits (3)

e85ff3b Fixed test configuration.
f232ddf Added constructor test.
b342487 Simplified the Json provider.

📊 Changes

4 files changed (+124 additions, -40 deletions)

View changed files

📝 phpunit.xml (+24 -8)
📝 src/JsonStorageProvider.php (+61 -21)
📝 tests/JsonStorageProviderTest.php (+39 -8)
➖ tests/bootstrap.php (+0 -3)

📄 Description

I've simplified the JSON Storage provider and removed some of the complexity and code duplication.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/yswery/PHP-DNS-SERVER/pull/21 **Author:** [@samuelwilliams](https://github.com/samuelwilliams) **Created:** 4/11/2017 **Status:** ✅ Merged **Merged:** 4/14/2017 **Merged by:** [@yswery](https://github.com/yswery) **Base:** `master` ← **Head:** `JSON_Storage` --- ### 📝 Commits (3) - [`e85ff3b`](https://github.com/yswery/PHP-DNS-SERVER/commit/e85ff3b5fa08b2ca251e1405d61bd35fda8e2f63) Fixed test configuration. - [`f232ddf`](https://github.com/yswery/PHP-DNS-SERVER/commit/f232ddfe8368c911eb7da47baf27128d7dad8c6e) Added constructor test. - [`b342487`](https://github.com/yswery/PHP-DNS-SERVER/commit/b3424874ec7aa720fd5982b42e97ed7cebd39700) Simplified the Json provider. ### 📊 Changes **4 files changed** (+124 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `phpunit.xml` (+24 -8) 📝 `src/JsonStorageProvider.php` (+61 -21) 📝 `tests/JsonStorageProviderTest.php` (+39 -8) ➖ `tests/bootstrap.php` (+0 -3) </details> ### 📄 Description I've simplified the JSON Storage provider and removed some of the complexity and code duplication. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>