[GH-ISSUE #92] Make meaningful inheritance possible, change private properties to protected #34

New issue

Closed

opened 2026-03-04 23:23:55 +03:00 by kerem · 4 comments

kerem commented

2026-03-04 23:23:55 +03:00

Owner

Originally created by @ampaze on GitHub (Feb 20, 2020).
Original GitHub issue: https://github.com/yswery/PHP-DNS-SERVER/issues/92

I want to inherit from DNS\Server and add a stop method, which is not possible as $loop and all other properties are private. Can this be changed? I could make a PR if needed.

Originally created by @ampaze on GitHub (Feb 20, 2020). Original GitHub issue: https://github.com/yswery/PHP-DNS-SERVER/issues/92 I want to inherit from `DNS\Server` and add a `stop` method, which is not possible as `$loop` and all other properties are private. Can this be changed? I could make a PR if needed.

kerem closed this issue

2026-03-04 23:23:55 +03:00

kerem commented

2026-03-04 23:23:56 +03:00

Author

Owner

@samuelwilliams commented on GitHub (Feb 20, 2020):

Hi, send through a PR changing the methods that you need access to.

@samuelwilliams commented on GitHub (Feb 20, 2020): Hi, send through a PR changing the methods that you need access to.

kerem commented

2026-03-04 23:23:57 +03:00

Author

Owner

@ampaze commented on GitHub (Feb 21, 2020):

Done. #93

@ampaze commented on GitHub (Feb 21, 2020): Done. #93

kerem commented

2026-03-04 23:23:57 +03:00

Author

Owner

@ampaze commented on GitHub (Feb 22, 2020):

Thanks!

@ampaze commented on GitHub (Feb 22, 2020): Thanks!

kerem commented

2026-03-04 23:23:57 +03:00

Author

Owner

@ampaze commented on GitHub (Feb 25, 2020):

Could you also make a new release?

Even using https://packagist.org/packages/yswery/dns#dev-master is not up to date.

@ampaze commented on GitHub (Feb 25, 2020): Could you also make a new release? Even using https://packagist.org/packages/yswery/dns#dev-master is not up to date.

kerem referenced this issue

2026-03-04 23:24:07 +03:00

[PR #34] [MERGED] Fix typos #60