mirror of
https://github.com/JLiscom/OpenNote.git
synced 2026-04-25 08:15:48 +03:00
[GH-ISSUE #8] Remove useless "OpenNote" folder #9
Labels
No labels
bug
enhancement
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/OpenNote-JLiscom#9
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @crazycodr on GitHub (Nov 5, 2013).
Original GitHub issue: https://github.com/JLiscom/OpenNote/issues/8
If people want to access the software from "/OpenNote" let them be. I recommend removing the OpenNote folder and merging everything down the the main folder.
Currently setting up composer in a fork and i'll add an IoC container. But to benefit from a standard setup structure, i'd strongly recommend we move OpenNote folder contents back into the main folder!
@crazycodr commented on GitHub (Nov 5, 2013):
Best yet, use a public folder as most application framework use a public folder to display public assets and hide controllers, views and other classes in the folder below it... I've yet to see a host that doesn't allow setting up vhosts to sub directories such as "/public"
@JLiscom commented on GitHub (Nov 6, 2013):
I like it the way it is.
I dislike clutter.
@crazycodr commented on GitHub (Nov 6, 2013):
It's ok to dislike clutter, but your application is hard to navigate in the code base portion and highly STUPID (Read on it on the web) you should adopt as early as possible good practices such the SOLID practices or risk failing your project on the long term.
Composer, PHPUnit, SOLID only to name a few are standards, not clutter. You will have a hard time acquiring contributors (except for bug reporters) if you stay this way. It's your call, good luck.
PS: I will still submit a pull request soon with the workload i did on your app, might seem like clutter, but i highly recommend you take a look at it and learn from it. Ask questions if you need help, i'll help you!