[GH-ISSUE #70] Error with HTML entities #61

Closed
opened 2026-02-26 01:35:03 +03:00 by kerem · 4 comments
Owner

Originally created by @mioux on GitHub (Jul 16, 2014).
Original GitHub issue: https://github.com/JLiscom/OpenNote/issues/70

I have posted a note with Google Chrome entitled "A télécharger" (which is correctly stored as "A télécharger")

When opening the note, HTML entities are correctly displayed, but not in preview...
Here is the error

error

In this screen, it is correct
ok

Originally created by @mioux on GitHub (Jul 16, 2014). Original GitHub issue: https://github.com/JLiscom/OpenNote/issues/70 I have posted a note with Google Chrome entitled "A télécharger" (which is correctly stored as "A télécharger") When opening the note, HTML entities are correctly displayed, but not in preview... Here is the error ![error](https://cloud.githubusercontent.com/assets/6904170/3603197/97d75764-0d14-11e4-98ec-ab0272a2b7d1.png) In this screen, it is correct ![ok](https://cloud.githubusercontent.com/assets/6904170/3603211/b812eed0-0d14-11e4-8c09-0356abfbdc38.png)
kerem 2026-02-26 01:35:03 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@JLiscom commented on GitHub (Jul 16, 2014):

Will track down

<!-- gh-comment-id:49223371 --> @JLiscom commented on GitHub (Jul 16, 2014): Will track down
Author
Owner

@mioux commented on GitHub (Jul 16, 2014):

For this one, I've found a workaround (I don't have tested the security of it)
In Service/model/pdo/Model.php, line 142

array($note->folderID,$note->originNoteID,htmlentities($note->title),htmlentities($note->note), $note->userID));//parse out for mys
ql use

replaced by

array($note->folderID,$note->originNoteID,$note->title,htmlentities($note->note), $note->userID));//parse out for mys
ql use

(I have removed htmlentities for the note title)

<!-- gh-comment-id:49226394 --> @mioux commented on GitHub (Jul 16, 2014): For this one, I've found a workaround (I don't have tested the security of it) In Service/model/pdo/Model.php, line 142 array($note->folderID,$note->originNoteID,htmlentities($note->title),htmlentities($note->note), $note->userID));//parse out for mys\ ql use replaced by array($note->folderID,$note->originNoteID,$note->title,htmlentities($note->note), $note->userID));//parse out for mys\ ql use (I have removed htmlentities for the note title)
Author
Owner

@JLiscom commented on GitHub (Jul 17, 2014):

@mioux
Not all flows decoded.
The patch above should fix that.

<!-- gh-comment-id:49249748 --> @JLiscom commented on GitHub (Jul 17, 2014): @mioux Not all flows decoded. The patch above should fix that.
Author
Owner

@mioux commented on GitHub (Jul 17, 2014):

Tested : OK (I have removed my modification before patching)

<!-- gh-comment-id:49264633 --> @mioux commented on GitHub (Jul 17, 2014): Tested : OK (I have removed my modification before patching)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OpenNote-JLiscom#61
No description provided.