[GH-ISSUE #155] Can you keep the entire HTTP response in the postOAuthRequestTokenWithCallbackURL? #94

New issue

Closed

opened 2026-03-03 16:45:37 +03:00 by kerem · 2 comments

kerem commented

2026-03-03 16:45:37 +03:00

Owner

Originally created by @SokichiFujita on GitHub (Dec 12, 2015).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/155

I would like to use the entire HTTP response of access token endpoint in the authorizeWithCallbackURL of OAuth1Swift. But postOAuthRequestTokenWithCallbackURL drops a lot of information from it.

In spite of Twitter returns user_id and screen_name with access_token and access_token_secret, postOAuthRequestTokenWithCallbackURL method only pass access_token and access_token_secret. Another information is dropped. I think user_id or screen_name are also important for apps.

I want to use following success handler:

public typealias TokenSuccessHandler = (credential: OAuthSwiftCredential, data: NSData, response: NSURLResponse) -> Void

Current success handler:

public typealias TokenSuccessHandler = (credential: OAuthSwiftCredential, response: NSURLResponse) -> Void

How do you think about this idea?

Originally created by @SokichiFujita on GitHub (Dec 12, 2015). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/155 I would like to use the entire HTTP response of access token endpoint in the `authorizeWithCallbackURL` of `OAuth1Swift`. But `postOAuthRequestTokenWithCallbackURL` drops a lot of information from it. In spite of Twitter returns `user_id` and `screen_name` with `access_token` and `access_token_secret`, `postOAuthRequestTokenWithCallbackURL` method only pass `access_token` and `access_token_secret`. Another information is dropped. I think `user_id` or `screen_name` are also important for apps. I want to use following success handler: ``` public typealias TokenSuccessHandler = (credential: OAuthSwiftCredential, data: NSData, response: NSURLResponse) -> Void ``` Current success handler: ``` public typealias TokenSuccessHandler = (credential: OAuthSwiftCredential, response: NSURLResponse) -> Void ``` How do you think about this idea?

kerem closed this issue

2026-03-03 16:45:38 +03:00

kerem commented

2026-03-03 16:45:38 +03:00

Author

Owner

@phimage commented on GitHub (Dec 12, 2015):

Did you look master branch head code in OAuthSwift.swift?
Someone make a PR to add to TokenSuccessHandler 'parameters'
Maybe in this dictionnary there is the information you looking for

@phimage commented on GitHub (Dec 12, 2015): Did you look master branch head code in OAuthSwift.swift? Someone make a PR to add to TokenSuccessHandler 'parameters' Maybe in this dictionnary there is the information you looking for

kerem commented

2026-03-03 16:45:38 +03:00

Author

Owner

@SokichiFujita commented on GitHub (Dec 12, 2015):

Thank you! #152 fixed this issue, as you mentioned.
parameters has the information that I need.

@SokichiFujita commented on GitHub (Dec 12, 2015): Thank you! #152 fixed this issue, as you mentioned. `parameters` has the information that I need.

kerem referenced this issue

2026-03-03 16:49:13 +03:00

[PR #97] [MERGED] Fix #94 set credential oauth2 var to true when succeeding to connect… #514