starred/OAuthSwift

Fork 0

mirror of https://github.com/OAuthSwift/OAuthSwift.git synced 2026-04-26 12:45:52 +03:00

[GH-ISSUE #135] watchOS 2.0 support? #83

New issue

Closed

opened 2026-03-03 16:45:32 +03:00 by kerem · 4 comments

kerem commented

2026-03-03 16:45:32 +03:00

Owner

Originally created by @mohwaili on GitHub (Oct 31, 2015).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/135

Will the watchOS 2.0 get any support?

Originally created by @mohwaili on GitHub (Oct 31, 2015). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/135 Will the watchOS 2.0 get any support?

kerem

2026-03-03 16:45:32 +03:00

closed this issue
added the
enhancement
label

kerem commented

2026-03-03 16:45:33 +03:00

Author

Owner

@sucharuhasija commented on GitHub (Oct 31, 2015):

Yes
On 31-Oct-2015 9:39 pm, "mohwaili" notifications@github.com wrote:

will the watchOS 2.0 be supported?

—
Reply to this email directly or view it on GitHub
https://github.com/dongri/OAuthSwift/issues/135.

@sucharuhasija commented on GitHub (Oct 31, 2015): Yes On 31-Oct-2015 9:39 pm, "mohwaili" notifications@github.com wrote: > will the watchOS 2.0 be supported? > > — > Reply to this email directly or view it on GitHub > https://github.com/dongri/OAuthSwift/issues/135.

kerem commented

2026-03-03 16:45:33 +03:00

Author

Owner

@phimage commented on GitHub (Oct 31, 2015):

must edit podspec and add

s.watchos.deployment_target = '2.0'
s.tvos.deployment_target = '9.0'

then add in code watchos ant tvos case (#if os (watchOS)) when there is

#if os(iOS)

I can PR next week but don't know when PR will be merged

@phimage commented on GitHub (Oct 31, 2015): must edit podspec and add ``` s.watchos.deployment_target = '2.0' s.tvos.deployment_target = '9.0' ``` then add in code watchos ant tvos case (`#if os (watchOS)`) when there is ``` #if os(iOS) ``` I can PR next week but don't know when PR will be merged

kerem commented

2026-03-03 16:45:33 +03:00

Author

Owner

@phimage commented on GitHub (Nov 9, 2015):

@mohwaili or @sucharuhasija did you make development for watchos ?
Is it really necessary to make a framework compatible with watchos because when I create a project on xcode, all controller code seems to be executed on iOS, only UI is on the watch, but maybe I am wrong

I already add compatibility into podspec with one of my own project and see that watch os compile code with i386 , not x86_64 '(and have some bugs)

@phimage commented on GitHub (Nov 9, 2015): @mohwaili or @sucharuhasija did you make development for watchos ? Is it really necessary to make a framework compatible with watchos because when I create a project on xcode, all controller code seems to be executed on iOS, only UI is on the watch, but maybe I am wrong I already add compatibility into podspec with one of my own project and see that watch os compile code with i386 , not x86_64 '(and have some bugs)

kerem commented

2026-03-03 16:45:33 +03:00

Author

Owner

@mohwaili commented on GitHub (Nov 9, 2015):

@phimage The problem I had is: my project has a shared framework and I wanted to reuse it for the apple watch (since watch os2 it's only possible when duplicating the framework target). The user authentication is embedded in this shared framework, when installing the pod I received an error. So the quick fix was adding watch os2 support without changing anything in my shared framework.

The answer to your question: it's not necessary to add watch os2 support, I should have had considered this issue from the beginning. Now I've separated the login and authentication from the shared framework and everything is working.

@mohwaili commented on GitHub (Nov 9, 2015): @phimage The problem I had is: my project has a shared framework and I wanted to reuse it for the apple watch (since watch os2 it's only possible when duplicating the framework target). The user authentication is embedded in this shared framework, when installing the pod I received an error. So the quick fix was adding watch os2 support without changing anything in my shared framework. The answer to your question: it's not necessary to add watch os2 support, I should have had considered this issue from the beginning. Now I've separated the login and authentication from the shared framework and everything is working.

kerem referenced this issue

2026-03-03 16:49:11 +03:00

[PR #83] [MERGED] Handle cancellation of the Authentication #508

kerem referenced this issue

2026-03-03 16:49:13 +03:00

[PR #106] [CLOSED] Mattia/sync upstream #516