[GH-ISSUE #122] Credential User ID and Refresh Token has been removed #74

Closed
opened 2026-03-03 16:45:27 +03:00 by kerem · 3 comments
Owner

Originally created by @jwrigh26 on GitHub (Oct 7, 2015).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/122

Comparing to an older version, within class OAuthSwiftCredential the two public vars user_id and refresh_token have been removed. Did some testing and when you go to step #3 on OAuth1Swift.swift, the user_id parameter is still being returned but you are no longer adding the credential of the client.

Plus there is no way to get this back ourselves without altering the library because you only pass the response back into the closure.

Adding this back would be awesome!

Originally created by @jwrigh26 on GitHub (Oct 7, 2015). Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/122 Comparing to an older version, within class OAuthSwiftCredential the two public vars user_id and refresh_token have been removed. Did some testing and when you go to step #3 on OAuth1Swift.swift, the user_id parameter is still being returned but you are no longer adding the credential of the client. Plus there is no way to get this back ourselves without altering the library because you only pass the response back into the closure. Adding this back would be awesome!
kerem closed this issue 2026-03-03 16:45:28 +03:00
Author
Owner

@phimage commented on GitHub (Oct 7, 2015):

I don't know anything about old release, could you specify the "older version" tag
to see user_id into OAuthSwiftCredential

<!-- gh-comment-id:146205070 --> @phimage commented on GitHub (Oct 7, 2015): I don't know anything about old release, could you specify the "older version" tag to see `user_id` into `OAuthSwiftCredential`
Author
Owner

@jwrigh26 commented on GitHub (Oct 7, 2015):

So the story goes the developers that were working on a co-project included the library as a framework. I can show a screen shot of the variables. I'm now wondering if they edited your work without documenting anywhere there changes. Do you know if you ever included these two variables in OAuthSwiftCredential?

user_id
refresh_token

screen shot 2015-10-07 at 10 34 41 am

<!-- gh-comment-id:146213217 --> @jwrigh26 commented on GitHub (Oct 7, 2015): So the story goes the developers that were working on a co-project included the library as a framework. I can show a screen shot of the variables. I'm now wondering if they edited your work without documenting anywhere there changes. Do you know if you ever included these two variables in OAuthSwiftCredential? user_id refresh_token ![screen shot 2015-10-07 at 10 34 41 am](https://cloud.githubusercontent.com/assets/8534039/10340649/2b590750-6cdf-11e5-8dd4-b6ca0e1ce1a6.png)
Author
Owner

@jwrigh26 commented on GitHub (Oct 7, 2015):

I apologize. I went looking at all previous versions and those two variables were never used. I do like the use of those two variables. But I believe it should have been properly forked and then submitted back to you to decide if you wanted to add this to your library.

I will close this issue. Sorry for wasting your time.

<!-- gh-comment-id:146214850 --> @jwrigh26 commented on GitHub (Oct 7, 2015): I apologize. I went looking at all previous versions and those two variables were never used. I do like the use of those two variables. But I believe it should have been properly forked and then submitted back to you to decide if you wanted to add this to your library. I will close this issue. Sorry for wasting your time.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#74
No description provided.