mirror of
https://github.com/OAuthSwift/OAuthSwift.git
synced 2026-04-26 12:45:52 +03:00
[GH-ISSUE #122] Credential User ID and Refresh Token has been removed #74
Labels
No labels
bug
cocoapod
duplicate
enhancement
feature-request
help wanted
help wanted
invalid
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/OAuthSwift#74
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jwrigh26 on GitHub (Oct 7, 2015).
Original GitHub issue: https://github.com/OAuthSwift/OAuthSwift/issues/122
Comparing to an older version, within class OAuthSwiftCredential the two public vars user_id and refresh_token have been removed. Did some testing and when you go to step #3 on OAuth1Swift.swift, the user_id parameter is still being returned but you are no longer adding the credential of the client.
Plus there is no way to get this back ourselves without altering the library because you only pass the response back into the closure.
Adding this back would be awesome!
@phimage commented on GitHub (Oct 7, 2015):
I don't know anything about old release, could you specify the "older version" tag
to see
user_idintoOAuthSwiftCredential@jwrigh26 commented on GitHub (Oct 7, 2015):
So the story goes the developers that were working on a co-project included the library as a framework. I can show a screen shot of the variables. I'm now wondering if they edited your work without documenting anywhere there changes. Do you know if you ever included these two variables in OAuthSwiftCredential?
user_id
refresh_token
@jwrigh26 commented on GitHub (Oct 7, 2015):
I apologize. I went looking at all previous versions and those two variables were never used. I do like the use of those two variables. But I believe it should have been properly forked and then submitted back to you to decide if you wanted to add this to your library.
I will close this issue. Sorry for wasting your time.