[PR #699] [MERGED] Remove usage of SFAuthenticationErrorDomain to avoid getting app rejection #724

New issue

Closed

opened 2026-03-03 17:29:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/699
Author: @raxityo
Created: 6/7/2022
Status: ✅ Merged
Merged: 6/7/2022
Merged by: @phatblat

Base: master ← Head: rax/fix/remove-SFAuthenticationErrorDomain

📝 Commits (1)

a6551ec Remove usage of SFAuthenticationErrorDomain to avoid getting app rejection

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 Sources/Handler/SFAuthenticationURLHandler.swift (+1 -2)

📄 Description

One of our apps recently received a rejection from Apple because to the usage of _SFAuthenticationErrorDomain, which is now considered a private API after being deprecated in iOS 12.0. The rejection included the following message:

ITMS-90338: Non-public API usage - The app references non-public symbols in <APP_NAME>: _SFAuthenticationErrorDomain. If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions. In addition, note that one or more of the above APIs may be located in a static library that was included with your app. If so, they must be removed. For further information, visit the Technical Support Information at http://developer.apple.com/support/technical/

In this PR, I am proposing to remove the usage of SFAuthenticationErrorDomain to avoid getting the app rejection. However, it's perhaps a good time to drop the support for SFAuthenticationSession support altogether from OAuthSwift with a major version change of OAuthSwift since it has been deprecated for ~4 years. But I will leave that to a separate discussion topic.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/699 **Author:** [@raxityo](https://github.com/raxityo) **Created:** 6/7/2022 **Status:** ✅ Merged **Merged:** 6/7/2022 **Merged by:** [@phatblat](https://github.com/phatblat) **Base:** `master` ← **Head:** `rax/fix/remove-SFAuthenticationErrorDomain` --- ### 📝 Commits (1) - [`a6551ec`](https://github.com/OAuthSwift/OAuthSwift/commit/a6551ec72e92ea39491ec671eb59742230f7fa42) Remove usage of SFAuthenticationErrorDomain to avoid getting app rejection ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Sources/Handler/SFAuthenticationURLHandler.swift` (+1 -2) </details> ### 📄 Description One of our apps recently received a rejection from Apple because to the usage of `_SFAuthenticationErrorDomain`, which is now considered a private API after being deprecated in iOS 12.0. The rejection included the following message: > ITMS-90338: Non-public API usage - The app references non-public symbols in <APP_NAME>: _SFAuthenticationErrorDomain. If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions. In addition, note that one or more of the above APIs may be located in a static library that was included with your app. If so, they must be removed. For further information, visit the Technical Support Information at http://developer.apple.com/support/technical/ In this PR, I am proposing to remove the usage of `SFAuthenticationErrorDomain` to avoid getting the app rejection. However, it's perhaps a good time to drop the support for `SFAuthenticationSession` support altogether from OAuthSwift with a major version change of `OAuthSwift` since it has been deprecated for ~4 years. But I will leave that to a separate discussion topic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>