[PR #696] Fix reversed log level check. #722

New issue

Open

opened 2026-03-03 17:29:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/696
Author: @markusrydh
Created: 4/21/2022
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (2)

82daabd Fix reversed log level check. If e.g. setting trace log level then warn and error messages are no longer logged.
0ece3b6 Include both error and error_description in serverError.

📊 Changes

4 files changed (+10 additions, -11 deletions)

View changed files

📝 Sources/OAuth2Swift.swift (+2 -3)
📝 Sources/OAuthLogProtocol.swift (+3 -3)
📝 Sources/OAuthSwiftClient.swift (+1 -1)
📝 Sources/OAuthSwiftError.swift (+4 -4)

📄 Description

Messages for a higher log level than the set log level were not logged due to inverted logic.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/696 **Author:** [@markusrydh](https://github.com/markusrydh) **Created:** 4/21/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`82daabd`](https://github.com/OAuthSwift/OAuthSwift/commit/82daabde9ce51c3796f2d6827f51c7360a2e9060) Fix reversed log level check. If e.g. setting trace log level then warn and error messages are no longer logged. - [`0ece3b6`](https://github.com/OAuthSwift/OAuthSwift/commit/0ece3b6f16b28dd99fa6df005ab2f0338a98f320) Include both error and error_description in serverError. ### 📊 Changes **4 files changed** (+10 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuth2Swift.swift` (+2 -3) 📝 `Sources/OAuthLogProtocol.swift` (+3 -3) 📝 `Sources/OAuthSwiftClient.swift` (+1 -1) 📝 `Sources/OAuthSwiftError.swift` (+4 -4) </details> ### 📄 Description Messages for a higher log level than the set log level were not logged due to inverted logic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>