667 #715

New issue

Open

opened 2026-03-03 17:29:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/672
Author: @MikeSpelling
Created: 8/12/2021
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (1)

0b346b9 Move the default timeoutInterval from OAuthSwiftHTTPRequest's Config initialiser up to the top level OAuth1/2Swift functions to allow them to be overriden.

📊 Changes

4 files changed (+58 additions, -56 deletions)

View changed files

📝 Sources/OAuth1Swift.swift (+7 -7)
📝 Sources/OAuth2Swift.swift (+18 -16)
📝 Sources/OAuthSwiftClient.swift (+31 -31)
📝 Sources/OAuthSwiftHTTPRequest.swift (+2 -2)

📄 Description

Rather than providing a default timeout in the Config initialiser which is never overriden I've moved this up to the top level requests. This should mean its a non-breaking change but allows a timeoutInterval to be passed where needed and used by the UrlRequest.
This is my first open source contribution so I welcome any feedback - thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/672 **Author:** [@MikeSpelling](https://github.com/MikeSpelling) **Created:** 8/12/2021 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`0b346b9`](https://github.com/OAuthSwift/OAuthSwift/commit/0b346b985e75991a7c4b30988b8dbc413d072db7) Move the default timeoutInterval from OAuthSwiftHTTPRequest's Config initialiser up to the top level OAuth1/2Swift functions to allow them to be overriden. ### 📊 Changes **4 files changed** (+58 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuth1Swift.swift` (+7 -7) 📝 `Sources/OAuth2Swift.swift` (+18 -16) 📝 `Sources/OAuthSwiftClient.swift` (+31 -31) 📝 `Sources/OAuthSwiftHTTPRequest.swift` (+2 -2) </details> ### 📄 Description Rather than providing a default timeout in the Config initialiser which is never overriden I've moved this up to the top level requests. This should mean its a non-breaking change but allows a timeoutInterval to be passed where needed and used by the UrlRequest. This is my first open source contribution so I welcome any feedback - thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>