669 #714

New issue

Closed

opened 2026-03-03 17:29:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/671
Author: @dillon-mce
Created: 8/9/2021
Status: ❌ Closed

Base: master ← Head: fix-xcode-13-compiler-errors

📝 Commits (1)

48ce326 Fixes OAuthSwift/OAuthSwift/issues/669

📊 Changes

17 files changed (+26 additions, -0 deletions)

View changed files

📝 Sources/Handler/ASWebAuthenticationURLHandler.swift (+2 -0)
📝 Sources/Handler/OAuthSwiftOpenURLExternally.swift (+1 -0)
📝 Sources/Handler/OAuthWebViewController.swift (+1 -0)
📝 Sources/Handler/SFAuthenticationURLHandler.swift (+2 -0)
📝 Sources/Handler/SafariURLHandler.swift (+1 -0)
📝 Sources/NSError+OAuthSwift.swift (+1 -0)
📝 Sources/NotificationCenter+OAuthSwift.swift (+2 -0)
📝 Sources/OAuth1Swift.swift (+1 -0)
📝 Sources/OAuth2Swift.swift (+1 -0)
📝 Sources/OAuthSwift.swift (+4 -0)
📝 Sources/OAuthSwiftClient.swift (+1 -0)
📝 Sources/OAuthSwiftCredential.swift (+2 -0)
📝 Sources/OAuthSwiftError.swift (+1 -0)
📝 Sources/OAuthSwiftHTTPRequest.swift (+3 -0)
📝 Sources/OAuthSwiftURLHandlerType.swift (+1 -0)
📝 Sources/String+OAuthSwift.swift (+1 -0)
📝 Sources/UIApplication+OAuthSwift.swift (+1 -0)

📄 Description

This PR addresses a build error which appears to be caused by a change introduced in Xcode 13 beta 3:

Linking Swift packages from application extension targets or watchOS applications no longer emits unresolvable warnings about linking to libraries not safe for use in application extensions. This means that code referencing APIs annotated as unavailable for use in app extensions must now themselves be annotated as unavailable for use in application extensions, in order to allow that code to be used in both apps and app extensions. (66928265)

I tried to keep the scope as limited as possible, and tested as much as I could and I don't think it broke anything, but it is definitely possible that I missed something. It is my first contribution to an open source project so I'm happy to take any feedback and implement changes. Just let me know. Thanks!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/671 **Author:** [@dillon-mce](https://github.com/dillon-mce) **Created:** 8/9/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix-xcode-13-compiler-errors` --- ### 📝 Commits (1) - [`48ce326`](https://github.com/OAuthSwift/OAuthSwift/commit/48ce326a1ad9dfe088c9ec57e8f0cd8c5b4e5d42) Fixes OAuthSwift/OAuthSwift/issues/669 ### 📊 Changes **17 files changed** (+26 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Sources/Handler/ASWebAuthenticationURLHandler.swift` (+2 -0) 📝 `Sources/Handler/OAuthSwiftOpenURLExternally.swift` (+1 -0) 📝 `Sources/Handler/OAuthWebViewController.swift` (+1 -0) 📝 `Sources/Handler/SFAuthenticationURLHandler.swift` (+2 -0) 📝 `Sources/Handler/SafariURLHandler.swift` (+1 -0) 📝 `Sources/NSError+OAuthSwift.swift` (+1 -0) 📝 `Sources/NotificationCenter+OAuthSwift.swift` (+2 -0) 📝 `Sources/OAuth1Swift.swift` (+1 -0) 📝 `Sources/OAuth2Swift.swift` (+1 -0) 📝 `Sources/OAuthSwift.swift` (+4 -0) 📝 `Sources/OAuthSwiftClient.swift` (+1 -0) 📝 `Sources/OAuthSwiftCredential.swift` (+2 -0) 📝 `Sources/OAuthSwiftError.swift` (+1 -0) 📝 `Sources/OAuthSwiftHTTPRequest.swift` (+3 -0) 📝 `Sources/OAuthSwiftURLHandlerType.swift` (+1 -0) 📝 `Sources/String+OAuthSwift.swift` (+1 -0) 📝 `Sources/UIApplication+OAuthSwift.swift` (+1 -0) </details> ### 📄 Description This PR addresses a build error which appears to be caused by a change introduced in Xcode 13 beta 3: > Linking Swift packages from application extension targets or watchOS applications no longer emits unresolvable warnings about linking to libraries not safe for use in application extensions. This means that code referencing APIs annotated as unavailable for use in app extensions must now themselves be annotated as unavailable for use in application extensions, in order to allow that code to be used in both apps and app extensions. (66928265) I tried to keep the scope as limited as possible, and tested as much as I could and I don't think it broke anything, but it is definitely possible that I missed something. It is my first contribution to an open source project so I'm happy to take any feedback and implement changes. Just let me know. Thanks! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>