[PR #643] [MERGED] Restore lint-ability to OAuthSwift Podspec #698

New issue

Closed

opened 2026-03-03 17:29:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/643
Author: @macbellingrath
Created: 1/19/2021
Status: ✅ Merged
Merged: 5/13/2021
Merged by: @phatblat

Base: master ← Head: bug/fix-podspec

📝 Commits (2)

4ec7559 [Fix] repairs conditional compilation for platforms that are currently failing during pod lint
56b8ef5 Merge branch 'master' into bug/fix-podspec

📊 Changes

3 files changed (+14 additions, -23 deletions)

View changed files

📝 OAuthSwift.podspec (+3 -0)
📝 Sources/Handler/ASWebAuthenticationURLHandler.swift (+6 -8)
📝 Sources/OAuth2Swift.swift (+5 -15)

📄 Description

Background:
The podspec definition on the main branch lists support for iOS, watchOS, tvOS, macOS but if one creates a target (as CocoaPods does during lint) for watchOS or tvOS, it can be seen that ASWebAuthenticationURLHandler isn't supported on those platforms.

Because of how the conditional compilation was written - (nested #if ) the entire class is actually only available on iOS currently. It would appear that the dependency ASWebAuthenticationURLHandler has on ASWebAuthenticationSession is available for macCatalyst targets, however, and I've left that intact.

The Podspec is also failing to list its system framework dependencies. For iOS 9..<12 targets, OAuthSwift depends on SafariServices, and on 12+, it also depends on AuthenticationServices. I've added those to the Podspec.

With these changes - the pod can be pushed to specs and will succeed to lint.

Thank you for contributing to OSS and taking time to review this diff.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/643 **Author:** [@macbellingrath](https://github.com/macbellingrath) **Created:** 1/19/2021 **Status:** ✅ Merged **Merged:** 5/13/2021 **Merged by:** [@phatblat](https://github.com/phatblat) **Base:** `master` ← **Head:** `bug/fix-podspec` --- ### 📝 Commits (2) - [`4ec7559`](https://github.com/OAuthSwift/OAuthSwift/commit/4ec755968121aabaf3e259b785a29ad346c9214d) [Fix] repairs conditional compilation for platforms that are currently failing during pod lint - [`56b8ef5`](https://github.com/OAuthSwift/OAuthSwift/commit/56b8ef54db09ed0d9eedfa1bfd6b6c8d78591a8b) Merge branch 'master' into bug/fix-podspec ### 📊 Changes **3 files changed** (+14 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift.podspec` (+3 -0) 📝 `Sources/Handler/ASWebAuthenticationURLHandler.swift` (+6 -8) 📝 `Sources/OAuth2Swift.swift` (+5 -15) </details> ### 📄 Description Background: The podspec definition on the main branch lists support for iOS, watchOS, tvOS, macOS but if one creates a target (as CocoaPods does during lint) for watchOS or tvOS, it can be seen that ASWebAuthenticationURLHandler isn't supported on those platforms. Because of how the conditional compilation was written - (nested `#if `) the entire class is actually only available on iOS currently. It would appear that the dependency ASWebAuthenticationURLHandler has on ASWebAuthenticationSession is available for macCatalyst targets, however, and I've left that intact. The Podspec is also failing to list its system framework dependencies. For iOS 9..<12 targets, OAuthSwift depends on SafariServices, and on 12+, it also depends on AuthenticationServices. I've added those to the Podspec. With these changes - the pod can be pushed to specs and will succeed to lint. Thank you for contributing to OSS and taking time to review this diff. Related issues: https://github.com/OAuthSwift/OAuthSwift/issues/615 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>