[PR #623] [MERGED] Fix the signature format for PLAINTEXT #694

Closed
opened 2026-03-03 17:29:42 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/623
Author: @chrishannah
Created: 9/7/2020
Status: Merged
Merged: 11/10/2020
Merged by: @phimage

Base: masterHead: patch-1


📝 Commits (1)

  • 77a861b Fix the signature format for PLAINTEXT

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 Sources/OAuthSwiftCredential.swift (+4 -0)

📄 Description

I encountered an issue regarding the signature format when using PLAINTEXT as the signature method. And after doing some research and debugging, I found that OAuthSwift was formatting the signature incorrectly.

While this may not be the best solution, I have tested it with the (private) api that uses PLAINTEXT, and that does fix the issue.

Just for reference, the signature format for plaintext is highlighted in the Dropbox documentation.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/623 **Author:** [@chrishannah](https://github.com/chrishannah) **Created:** 9/7/2020 **Status:** ✅ Merged **Merged:** 11/10/2020 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`77a861b`](https://github.com/OAuthSwift/OAuthSwift/commit/77a861bb6bd12a806451301a44d238e65ec568bb) Fix the signature format for PLAINTEXT ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuthSwiftCredential.swift` (+4 -0) </details> ### 📄 Description I encountered an issue regarding the signature format when using PLAINTEXT as the signature method. And after doing some research and debugging, I found that OAuthSwift was formatting the signature incorrectly. While this may not be the best solution, I have tested it with the (private) api that uses PLAINTEXT, and that does fix the issue. Just for reference, the signature format for plaintext is highlighted in the [Dropbox documentation](https://dropbox.tech/developers/using-oauth-1-0-with-the-plaintext-signature-method). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 17:29:42 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#694
No description provided.