mirror of
https://github.com/OAuthSwift/OAuthSwift.git
synced 2026-04-26 12:45:52 +03:00
[PR #623] [MERGED] Fix the signature format for PLAINTEXT #694
Labels
No labels
bug
cocoapod
duplicate
enhancement
feature-request
help wanted
help wanted
invalid
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/OAuthSwift#694
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/623
Author: @chrishannah
Created: 9/7/2020
Status: ✅ Merged
Merged: 11/10/2020
Merged by: @phimage
Base:
master← Head:patch-1📝 Commits (1)
77a861bFix the signature format for PLAINTEXT📊 Changes
1 file changed (+4 additions, -0 deletions)
View changed files
📝
Sources/OAuthSwiftCredential.swift(+4 -0)📄 Description
I encountered an issue regarding the signature format when using PLAINTEXT as the signature method. And after doing some research and debugging, I found that OAuthSwift was formatting the signature incorrectly.
While this may not be the best solution, I have tested it with the (private) api that uses PLAINTEXT, and that does fix the issue.
Just for reference, the signature format for plaintext is highlighted in the Dropbox documentation.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.