[PR #605] [MERGED] Fix broken build when compiling for Mac Catalyst #689

New issue

Closed

opened 2026-03-03 17:29:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/605
Author: @Timac
Created: 6/21/2020
Status: ✅ Merged
Merged: 7/1/2020
Merged by: @phimage

Base: master ← Head: feature/FixCatalystBuild

📝 Commits (1)

94e2105 The revision 42e18ec60f45e1f51585410cd63758c1b47574cc introduced a build error when compiling for Mac Catalyst.

📊 Changes

1 file changed (+9 additions, -0 deletions)

View changed files

📝 Sources/OAuth2Swift.swift (+9 -0)

📄 Description

The revision 42e18ec60f45e1f51585410cd63758c1b47574cc introduced a build error when compiling for Mac Catalyst.

As you can see in SFAuthenticationURLHandler.swift, SFAuthenticationURLHandler is not defined on Catalyst:

#if !targetEnvironment(macCatalyst)
@available(iOS, introduced: 11.0, deprecated: 12.0)
open class SFAuthenticationURLHandler: OAuthSwiftURLHandlerType {
[...]
#endif

The proposed solution consists of using the same #if targetEnvironment(macCatalyst) to not use SFAuthenticationURLHandler when compiling for Catalyst.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/605 **Author:** [@Timac](https://github.com/Timac) **Created:** 6/21/2020 **Status:** ✅ Merged **Merged:** 7/1/2020 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `feature/FixCatalystBuild` --- ### 📝 Commits (1) - [`94e2105`](https://github.com/OAuthSwift/OAuthSwift/commit/94e21052e5ca088c45fc8e59595ff727062a45b5) The revision `42e18ec60f45e1f51585410cd63758c1b47574cc` introduced a build error when compiling for Mac Catalyst. ### 📊 Changes **1 file changed** (+9 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuth2Swift.swift` (+9 -0) </details> ### 📄 Description The revision `42e18ec60f45e1f51585410cd63758c1b47574cc` introduced a build error when compiling for Mac Catalyst. As you can see in `SFAuthenticationURLHandler.swift`, SFAuthenticationURLHandler is not defined on Catalyst: ``` #if !targetEnvironment(macCatalyst) @available(iOS, introduced: 11.0, deprecated: 12.0) open class SFAuthenticationURLHandler: OAuthSwiftURLHandlerType { [...] #endif ``` The proposed solution consists of using the same `#if targetEnvironment(macCatalyst)` to not use SFAuthenticationURLHandler when compiling for Catalyst. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>