[PR #612] [MERGED] Fix for compiling Mac Framework #688

New issue

Closed

opened 2026-03-03 17:29:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/612
Author: @tevendale
Created: 7/22/2020
Status: ✅ Merged
Merged: 7/27/2020
Merged by: @phimage

Base: master ← Head: Fix-for-Mac

📝 Commits (2)

b271fd9 Included OAuthLogProtocol.swift in MacFramework Target
cd265f8 Added Mac-Specific macros to successfully compile Mac Demo Target

📊 Changes

2 files changed (+7 additions, -0 deletions)

View changed files

📝 OAuthSwift.xcodeproj/project.pbxproj (+2 -0)
📝 Sources/OAuth2Swift.swift (+5 -0)

📄 Description

Unable to compile the Mac Framework Target in the latest build as per issue #661

I've popped in some platform-specific macros to remove the failing lines fro the Mac build, but I'm not sure if there are further implications from this change.

Also, OAuthLogProtocol.swift has been included in the Mac target for the framework

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/612 **Author:** [@tevendale](https://github.com/tevendale) **Created:** 7/22/2020 **Status:** ✅ Merged **Merged:** 7/27/2020 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `Fix-for-Mac` --- ### 📝 Commits (2) - [`b271fd9`](https://github.com/OAuthSwift/OAuthSwift/commit/b271fd925697e5d093ca5d2cfc3d8020dfde0008) Included OAuthLogProtocol.swift in MacFramework Target - [`cd265f8`](https://github.com/OAuthSwift/OAuthSwift/commit/cd265f875cc9fcb87cfa81d1f0d95e79e6235140) Added Mac-Specific macros to successfully compile Mac Demo Target ### 📊 Changes **2 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+2 -0) 📝 `Sources/OAuth2Swift.swift` (+5 -0) </details> ### 📄 Description Unable to compile the Mac Framework Target in the latest build as per issue #661 I've popped in some platform-specific macros to remove the failing lines fro the Mac build, but I'm not sure if there are further implications from this change. Also, OAuthLogProtocol.swift has been included in the Mac target for the framework --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>