[PR #599] [MERGED] handle SFAuthenticationSession/ASWebAuthenticationSession canceledLogin errors #686

New issue

Closed

opened 2026-03-03 17:29:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/599
Author: @eastsss
Created: 5/21/2020
Status: ✅ Merged
Merged: 5/24/2020
Merged by: @phimage

Base: master ← Head: master

📝 Commits (1)

42e18ec handling SFAuthenticationSession/ASWebAuthenticationSession canceledLogin errors

📊 Changes

3 files changed (+76 additions, -36 deletions)

View changed files

📝 Sources/Handler/ASWebAuthenticationURLHandler.swift (+26 -17)
📝 Sources/Handler/SFAuthenticationURLHandler.swift (+26 -15)
📝 Sources/OAuth2Swift.swift (+24 -4)

📄 Description

Allows to properly distinguish canceled logins from errors when using SFAuthenticationSession or ASWebAuthenticationSession. To implement this I have to pass error domain and error code inside callback url.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/599 **Author:** [@eastsss](https://github.com/eastsss) **Created:** 5/21/2020 **Status:** ✅ Merged **Merged:** 5/24/2020 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`42e18ec`](https://github.com/OAuthSwift/OAuthSwift/commit/42e18ec60f45e1f51585410cd63758c1b47574cc) handling SFAuthenticationSession/ASWebAuthenticationSession canceledLogin errors ### 📊 Changes **3 files changed** (+76 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `Sources/Handler/ASWebAuthenticationURLHandler.swift` (+26 -17) 📝 `Sources/Handler/SFAuthenticationURLHandler.swift` (+26 -15) 📝 `Sources/OAuth2Swift.swift` (+24 -4) </details> ### 📄 Description Allows to properly distinguish canceled logins from errors when using SFAuthenticationSession or ASWebAuthenticationSession. To implement this I have to pass error domain and error code inside callback url. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>