[PR #586] [MERGED] Add logging mechanism #684

New issue

Closed

opened 2026-03-03 17:29:39 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 17:29:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/586
Author: @svoip
Created: 4/20/2020
Status: ✅ Merged
Merged: 5/6/2020
Merged by: @phimage

Base: master ← Head: add-logging-mechanism

📝 Commits (4)

72c6919 Define logging protocol
5e11fde Implement logging usages
e2068d4 Add more log traces, set demo logging level
0bc09f1 Modify log calls

📊 Changes

11 files changed (+134 additions, -8 deletions)

View changed files

📝 Demo/Common/ViewController.swift (+3 -0)
📝 OAuthSwift.xcodeproj/project.pbxproj (+10 -6)
📝 Sources/Handler/ASWebAuthenticationURLHandler.swift (+2 -0)
📝 Sources/Handler/OAuthWebViewController.swift (+3 -0)
📝 Sources/Handler/SFAuthenticationURLHandler.swift (+1 -0)
📝 Sources/Handler/SafariURLHandler.swift (+3 -0)
📝 Sources/OAuth2Swift.swift (+22 -2)
➕ Sources/OAuthLogProtocol.swift (+67 -0)
📝 Sources/OAuthSwift.swift (+14 -0)
📝 Sources/OAuthSwiftCredential.swift (+7 -0)
📝 Sources/OAuthSwiftHTTPRequest.swift (+2 -0)

📄 Description

Can you check please if the log definitions and log calls are ok?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/586 **Author:** [@svoip](https://github.com/svoip) **Created:** 4/20/2020 **Status:** ✅ Merged **Merged:** 5/6/2020 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `add-logging-mechanism` --- ### 📝 Commits (4) - [`72c6919`](https://github.com/OAuthSwift/OAuthSwift/commit/72c691996b9168257289a7c7c7851fa5a8162a32) Define logging protocol - [`5e11fde`](https://github.com/OAuthSwift/OAuthSwift/commit/5e11fde1c6edee35a321c025aba39cb712096bda) Implement logging usages - [`e2068d4`](https://github.com/OAuthSwift/OAuthSwift/commit/e2068d4a1d0f45a23248dcf9a7f5e650a19825a4) Add more log traces, set demo logging level - [`0bc09f1`](https://github.com/OAuthSwift/OAuthSwift/commit/0bc09f1245de80c78f5fb66604a7c44645284e5c) Modify log calls ### 📊 Changes **11 files changed** (+134 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `Demo/Common/ViewController.swift` (+3 -0) 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+10 -6) 📝 `Sources/Handler/ASWebAuthenticationURLHandler.swift` (+2 -0) 📝 `Sources/Handler/OAuthWebViewController.swift` (+3 -0) 📝 `Sources/Handler/SFAuthenticationURLHandler.swift` (+1 -0) 📝 `Sources/Handler/SafariURLHandler.swift` (+3 -0) 📝 `Sources/OAuth2Swift.swift` (+22 -2) ➕ `Sources/OAuthLogProtocol.swift` (+67 -0) 📝 `Sources/OAuthSwift.swift` (+14 -0) 📝 `Sources/OAuthSwiftCredential.swift` (+7 -0) 📝 `Sources/OAuthSwiftHTTPRequest.swift` (+2 -0) </details> ### 📄 Description Can you check please if the log definitions and log calls are ok? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>