[PR #583] [MERGED] Remove redundant URL initializer call from README #682

Closed
opened 2026-03-03 17:29:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/583
Author: @MaxDesiatov
Created: 3/31/2020
Status: Merged
Merged: 5/6/2020
Merged by: @phimage

Base: masterHead: patch-2


📝 Commits (1)

  • 140ed3f Remove redundant URL initializer call from README

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 README.md (+3 -3)

📄 Description

All these function calls take URLConvertible as an argument, and String is also URLConvertible. Thus URL(string:) initializer call is redundant and has a negative impact on readability of the example code in README.md.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/583 **Author:** [@MaxDesiatov](https://github.com/MaxDesiatov) **Created:** 3/31/2020 **Status:** ✅ Merged **Merged:** 5/6/2020 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `patch-2` --- ### 📝 Commits (1) - [`140ed3f`](https://github.com/OAuthSwift/OAuthSwift/commit/140ed3fcb13ee29ae76b5dba57f0431a505baecf) Remove redundant URL initializer call from README ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -3) </details> ### 📄 Description All these function calls take `URLConvertible` as an argument, and `String` is also `URLConvertible`. Thus `URL(string:)` initializer call is redundant and has a negative impact on readability of the example code in `README.md`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 17:29:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#682
No description provided.