[PR #558] [CLOSED] fire dismiss handler when safariViewControllerDidFinish(control… #667

New issue

Closed

opened 2026-03-03 16:49:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/558
Author: @karrybit
Created: 11/15/2019
Status: ❌ Closed

Base: master ← Head: dismissHandlerWhenDidFinishSafari

📝 Commits (2)

4847905 [fix] fire dismiss handler when safariViewControllerDidFinish(controller:)
63a4fda fix to call method

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 Sources/Handler/SafariURLHandler.swift (+1 -0)

📄 Description

I always use it conveniently. Thank you very much.

The dismiss completion did not work when the [DONE] button in Safari was tapped.
Since I had activated of UIActivityIndicatorView before transitioning to Safari, I needed dismissHandler to stop it.

I modified to work the dismissHandler when safariViewControllerDidFinish(:controller) fires.

Thank you for the review.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/558 **Author:** [@karrybit](https://github.com/karrybit) **Created:** 11/15/2019 **Status:** ❌ Closed **Base:** `master` ← **Head:** `dismissHandlerWhenDidFinishSafari` --- ### 📝 Commits (2) - [`4847905`](https://github.com/OAuthSwift/OAuthSwift/commit/4847905bd1fd73af3929e2c51b28429971d8a836) [fix] fire dismiss handler when safariViewControllerDidFinish(controller:) - [`63a4fda`](https://github.com/OAuthSwift/OAuthSwift/commit/63a4fdac45f7c016814729b49a5b129c1118f059) fix to call method ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `Sources/Handler/SafariURLHandler.swift` (+1 -0) </details> ### 📄 Description I always use it conveniently. Thank you very much. The dismiss completion did not work when the [DONE] button in Safari was tapped. Since I had activated of UIActivityIndicatorView before transitioning to Safari, I needed dismissHandler to stop it. I modified to work the dismissHandler when safariViewControllerDidFinish(:controller) fires. Thank you for the review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>