[PR #527] [MERGED] Version 2.0.0 Use `Result` type #660

New issue

Closed

opened 2026-03-03 16:49:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/527
Author: @phimage
Created: 6/10/2019
Status: ✅ Merged
Merged: 6/10/2019
Merged by: @phimage

Base: master ← Head: 2.0.0

📝 Commits (4)

6e568eb Use Result type with one closure instead of success and failure handler
e4f88f4 Use completionHandler instead of completion in function signature
c1104e9 Documentation for using Result type
0ea666e Merge branch 'master' into 2.0.0

📊 Changes

19 files changed (+816 additions, -847 deletions)

View changed files

📝 Demo/Common/ViewController.swift (+469 -461)
📝 OAuthSwift.podspec (+1 -1)
📝 OAuthSwift.xcodeproj/project.pbxproj (+1 -5)
📝 OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwift.xcscheme (+1 -1)
📝 OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftMacOS.xcscheme (+1 -1)
📝 OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftTVOS.xcscheme (+1 -1)
📝 OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftWatchOS.xcscheme (+1 -1)
📝 OAuthSwiftTests/OAuth1SwiftTests.swift (+23 -28)
📝 OAuthSwiftTests/OAuth2SwiftTests.swift (+16 -20)
📝 OAuthSwiftTests/OAuthSwiftRequestTests.swift (+34 -27)
📝 OAuthSwiftTests/ServicesTests.swift (+15 -14)
📝 README.md (+40 -30)
📝 Sources/OAuth1Swift.swift (+77 -59)
📝 Sources/OAuth2Swift.swift (+93 -77)
📝 Sources/OAuthSwift.swift (+2 -3)
📝 Sources/OAuthSwiftClient.swift (+21 -21)
📝 Sources/OAuthSwiftError.swift (+7 -4)
📝 Sources/OAuthSwiftHTTPRequest.swift (+13 -18)
➖ Sources/Objc.swift (+0 -75)

📄 Description

This is a breaking change
Instead of two closure (success and failure handler) only one with Result

TODO

change closure
demo
test
choose between completion or completionHandler
doc

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/527 **Author:** [@phimage](https://github.com/phimage) **Created:** 6/10/2019 **Status:** ✅ Merged **Merged:** 6/10/2019 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `2.0.0` --- ### 📝 Commits (4) - [`6e568eb`](https://github.com/OAuthSwift/OAuthSwift/commit/6e568eb1ca10f0da29df90e7a8db1d0a972e799c) Use `Result` type with one closure instead of success and failure handler - [`e4f88f4`](https://github.com/OAuthSwift/OAuthSwift/commit/e4f88f43af10e0efc61b3cb98b2baf1aefad1ab0) Use `completionHandler` instead of `completion` in function signature - [`c1104e9`](https://github.com/OAuthSwift/OAuthSwift/commit/c1104e9744d75e5e2365c8ac28281bb509c14766) Documentation for using `Result` type - [`0ea666e`](https://github.com/OAuthSwift/OAuthSwift/commit/0ea666eff6e49c6772a8753d7e963c87e1fb91ab) Merge branch 'master' into 2.0.0 ### 📊 Changes **19 files changed** (+816 additions, -847 deletions) <details> <summary>View changed files</summary> 📝 `Demo/Common/ViewController.swift` (+469 -461) 📝 `OAuthSwift.podspec` (+1 -1) 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+1 -5) 📝 `OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwift.xcscheme` (+1 -1) 📝 `OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftMacOS.xcscheme` (+1 -1) 📝 `OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftTVOS.xcscheme` (+1 -1) 📝 `OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftWatchOS.xcscheme` (+1 -1) 📝 `OAuthSwiftTests/OAuth1SwiftTests.swift` (+23 -28) 📝 `OAuthSwiftTests/OAuth2SwiftTests.swift` (+16 -20) 📝 `OAuthSwiftTests/OAuthSwiftRequestTests.swift` (+34 -27) 📝 `OAuthSwiftTests/ServicesTests.swift` (+15 -14) 📝 `README.md` (+40 -30) 📝 `Sources/OAuth1Swift.swift` (+77 -59) 📝 `Sources/OAuth2Swift.swift` (+93 -77) 📝 `Sources/OAuthSwift.swift` (+2 -3) 📝 `Sources/OAuthSwiftClient.swift` (+21 -21) 📝 `Sources/OAuthSwiftError.swift` (+7 -4) 📝 `Sources/OAuthSwiftHTTPRequest.swift` (+13 -18) ➖ `Sources/Objc.swift` (+0 -75) </details> ### 📄 Description This is a breaking change Instead of two closure (success and failure handler) only one with `Result` TODO - [x] change closure - [x] demo - [x] test - [x] choose between `completion` or `completionHandler` - [x] doc --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>