[PR #473] [MERGED] OAuthSwiftCredential conforms to NSSecureCoding #641

New issue

Closed

opened 2026-03-03 16:49:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/473
Author: @slizeray
Created: 6/22/2018
Status: ✅ Merged
Merged: 6/25/2018
Merged by: @phimage

Base: master ← Head: master

📝 Commits (6)

d222669 Adapt NSSecureCoding Translate all decodeObject(forKey:) calls to decodeObject(of:forKey:)
c8eeaa3 single designated initializer with consumerKey & consumerSecret
b2e4ad8 conditional execution for iOS 8 support
932b9b4 compatibility with OSX 10.10
4ccc0e9 revert back the default initializer with no arguments, as request by @phimage
1be3897 changed requested by @phimage, use the default initializer before decoding....

📊 Changes

1 file changed (+75 additions, -12 deletions)

View changed files

📝 Sources/OAuthSwiftCredential.swift (+75 -12)

📄 Description

Follow recommendations:
Translate All decodeObject(forKey:) Calls to decodeObject(of:forKey:)
in
https://developer.apple.com/videos/play/wwdc2018/222/

decodeObject(forKey:) will be deprecated in iOS 12
take care of compatibility with iOS 8 and OSX 10.10

Get rid of designated initializer with no arguments, consumerKey and consumerSecret attributes are now immutable

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/473 **Author:** [@slizeray](https://github.com/slizeray) **Created:** 6/22/2018 **Status:** ✅ Merged **Merged:** 6/25/2018 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (6) - [`d222669`](https://github.com/OAuthSwift/OAuthSwift/commit/d2226694ab0e605761562347bcbacaf5612240e5) Adapt NSSecureCoding Translate all decodeObject(forKey:) calls to decodeObject(of:forKey:) - [`c8eeaa3`](https://github.com/OAuthSwift/OAuthSwift/commit/c8eeaa39c7b71dcef3c1c90183bc1da1884a5022) single designated initializer with consumerKey & consumerSecret - [`b2e4ad8`](https://github.com/OAuthSwift/OAuthSwift/commit/b2e4ad80a80a1c047687d388ef3c0c3aaa79eda7) conditional execution for iOS 8 support - [`932b9b4`](https://github.com/OAuthSwift/OAuthSwift/commit/932b9b4a3de3e466b975e0386adb27a8de5af99c) compatibility with OSX 10.10 - [`4ccc0e9`](https://github.com/OAuthSwift/OAuthSwift/commit/4ccc0e932e79b598159d8716401e4c18d2a461f6) revert back the default initializer with no arguments, as request by @phimage - [`1be3897`](https://github.com/OAuthSwift/OAuthSwift/commit/1be3897845f88724ff078db66444bc6021720b8c) changed requested by @phimage, use the default initializer before decoding.... ### 📊 Changes **1 file changed** (+75 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuthSwiftCredential.swift` (+75 -12) </details> ### 📄 Description Follow recommendations: Translate All decodeObject(forKey:) Calls to decodeObject(of:forKey:) in https://developer.apple.com/videos/play/wwdc2018/222/ - decodeObject(forKey:) will be deprecated in iOS 12 - take care of compatibility with iOS 8 and OSX 10.10 Get rid of designated initializer with no arguments, consumerKey and consumerSecret attributes are now immutable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>