[PR #461] [MERGED] Fix failing oauth1 tests Fix #460 #637

New issue

Closed

opened 2026-03-03 16:49:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/461
Author: @aranasaurus
Created: 5/15/2018
Status: ✅ Merged
Merged: 5/16/2018
Merged by: @phimage

Base: master ← Head: failing-oauth1-tests

📝 Commits (3)

bd5b9d7 Fix failing oauth1 tests
6f34e8d Add Cocoapods to Gemfile
ab99bfd Update iphonesimulator version to 11.3

📊 Changes

3 files changed (+3 additions, -2 deletions)

View changed files

📝 .travis.yml (+1 -1)
📝 Gemfile (+1 -0)
📝 Sources/OAuth1Swift.swift (+1 -1)

📄 Description

oauthbin is returning a 200 response with string data that explains the failure rather than a 400. The authorize method in this case is just using the OAuthSwiftCredential's default token value, which is an empty string. This change makes a response with an empty token value report as a missingToken error.

Fixes #460

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/461 **Author:** [@aranasaurus](https://github.com/aranasaurus) **Created:** 5/15/2018 **Status:** ✅ Merged **Merged:** 5/16/2018 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `failing-oauth1-tests` --- ### 📝 Commits (3) - [`bd5b9d7`](https://github.com/OAuthSwift/OAuthSwift/commit/bd5b9d7c8255f8c6273acfdf3ea9d161d5620eb5) Fix failing oauth1 tests - [`6f34e8d`](https://github.com/OAuthSwift/OAuthSwift/commit/6f34e8d6d4bb65d56025f432767ccca11def81a6) Add Cocoapods to Gemfile - [`ab99bfd`](https://github.com/OAuthSwift/OAuthSwift/commit/ab99bfd0d4a53b750080659334b8ff4d2452dd44) Update iphonesimulator version to 11.3 ### 📊 Changes **3 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+1 -1) 📝 `Gemfile` (+1 -0) 📝 `Sources/OAuth1Swift.swift` (+1 -1) </details> ### 📄 Description oauthbin is returning a 200 response with string data that explains the failure rather than a 400. The authorize method in this case is just using the OAuthSwiftCredential's default token value, which is an empty string. This change makes a response with an empty token value report as a `missingToken` error. Fixes #460 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>