[PR #452] [MERGED] - SafariURLHandler now referencing oauthSwift as weak var Fix #451 #634

New issue

Closed

opened 2026-03-03 16:49:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/452
Author: @shaibt
Created: 4/12/2018
Status: ✅ Merged
Merged: 4/12/2018
Merged by: @phimage

Base: master ← Head: master

📝 Commits (1)

497abf4 - SafariURLHandler now referencing oauthSwift as weak var (was strong let) to prevent retention cycle with OAuthSwift

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 Sources/OAuthSwiftURLHandlerType.swift (+2 -2)

📄 Description

(was strong let) to prevent retention cycle with OAuthSwift

Tested with single oAuth2.0 provider using SafariURLHandler.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/452 **Author:** [@shaibt](https://github.com/shaibt) **Created:** 4/12/2018 **Status:** ✅ Merged **Merged:** 4/12/2018 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`497abf4`](https://github.com/OAuthSwift/OAuthSwift/commit/497abf4da7518c672df1bc793a84085c5f488e9b) - SafariURLHandler now referencing oauthSwift as weak var (was strong let) to prevent retention cycle with OAuthSwift ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuthSwiftURLHandlerType.swift` (+2 -2) </details> ### 📄 Description (was strong let) to prevent retention cycle with OAuthSwift Tested with single oAuth2.0 provider using SafariURLHandler. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>