[PR #438] [MERGED] Fix incorrect coding key for signatureMethod on OAuthSwiftCredential when using a version of .oAuth1 #630

New issue

Closed

opened 2026-03-03 16:49:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/438
Author: @Michael-Place
Created: 2/26/2018
Status: ✅ Merged
Merged: 2/26/2018
Merged by: @phimage

Base: master ← Head: fix_oauthswiftcredential_nscoding_crash

📝 Commits (1)

6bf9b43 Fix incorrect coding key for OAuthSwiftCredential.signatureMethod for OAuth1 version

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Sources/OAuthSwiftCredential.swift (+1 -1)

📄 Description

The encode method was writing the value for signatureMethod to the key that was reserved for version. There was a type mismatch of String and Int32 which causes a crash on decode.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/438 **Author:** [@Michael-Place](https://github.com/Michael-Place) **Created:** 2/26/2018 **Status:** ✅ Merged **Merged:** 2/26/2018 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `fix_oauthswiftcredential_nscoding_crash` --- ### 📝 Commits (1) - [`6bf9b43`](https://github.com/OAuthSwift/OAuthSwift/commit/6bf9b43967e22967a7e180eba50e37134eaeac38) Fix incorrect coding key for OAuthSwiftCredential.signatureMethod for OAuth1 version ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuthSwiftCredential.swift` (+1 -1) </details> ### 📄 Description The encode method was writing the value for `signatureMethod` to the key that was reserved for version. There was a type mismatch of `String` and `Int32` which causes a crash on decode. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>