[PR #410] [MERGED] Migrate to Swift 4 Fix #409 #626

New issue

Closed

opened 2026-03-03 16:49:47 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/410
Author: @nighthawk
Created: 9/15/2017
Status: ✅ Merged
Merged: 9/16/2017
Merged by: @phimage

Base: master ← Head: master

📝 Commits (5)

5eca6c8 Migrate to Swift 4
0a4b64a Switch CI to Xcode 9 and iPhone 8
b622e58 Switch CI to iOS 11
b7f66d9 Fixing up project settings
12798bd Switch CI to macOS 10.13

📊 Changes

14 files changed (+59 additions, -49 deletions)

View changed files

📝 .travis.yml (+4 -4)
📝 OAuthSwift.xcodeproj/project.pbxproj (+29 -17)
📝 OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwift.xcscheme (+3 -1)
📝 OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftOSX.xcscheme (+3 -1)
📝 OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftTVOS.xcscheme (+3 -1)
📝 OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftWatchOS.xcscheme (+3 -1)
📝 OAuthSwiftTests/ServicesTests.swift (+0 -1)
📝 OAuthSwiftTests/SignTests.swift (+1 -1)
📝 Sources/Dictionary+OAuthSwift.swift (+0 -12)
📝 Sources/OAuthSwiftClient.swift (+1 -1)
📝 Sources/OAuthSwiftHTTPRequest.swift (+2 -2)
📝 Sources/OAuthSwiftURLHandlerType.swift (+1 -1)
📝 Sources/OAuthWebViewController.swift (+3 -3)
📝 Sources/String+OAuthSwift.swift (+6 -3)

📄 Description

Migrated to Swift 4 and Xcode 9. Tests succeeded when running locally, but best for someone to review.

Fixes issue #409.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/410 **Author:** [@nighthawk](https://github.com/nighthawk) **Created:** 9/15/2017 **Status:** ✅ Merged **Merged:** 9/16/2017 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`5eca6c8`](https://github.com/OAuthSwift/OAuthSwift/commit/5eca6c806894e0839535a3849b18f066ae9c2049) Migrate to Swift 4 - [`0a4b64a`](https://github.com/OAuthSwift/OAuthSwift/commit/0a4b64a6f4c44abd82742c036c718adf41e5809a) Switch CI to Xcode 9 and iPhone 8 - [`b622e58`](https://github.com/OAuthSwift/OAuthSwift/commit/b622e58a760f27ac63f9bbd8a1900b3e619443f6) Switch CI to iOS 11 - [`b7f66d9`](https://github.com/OAuthSwift/OAuthSwift/commit/b7f66d954b6934cc40a4e39103d1641bf8d187b7) Fixing up project settings - [`12798bd`](https://github.com/OAuthSwift/OAuthSwift/commit/12798bd2d6cbd7bea854d5dd444d4e54d173c62b) Switch CI to macOS 10.13 ### 📊 Changes **14 files changed** (+59 additions, -49 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+4 -4) 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+29 -17) 📝 `OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwift.xcscheme` (+3 -1) 📝 `OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftOSX.xcscheme` (+3 -1) 📝 `OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftTVOS.xcscheme` (+3 -1) 📝 `OAuthSwift.xcodeproj/xcshareddata/xcschemes/OAuthSwiftWatchOS.xcscheme` (+3 -1) 📝 `OAuthSwiftTests/ServicesTests.swift` (+0 -1) 📝 `OAuthSwiftTests/SignTests.swift` (+1 -1) 📝 `Sources/Dictionary+OAuthSwift.swift` (+0 -12) 📝 `Sources/OAuthSwiftClient.swift` (+1 -1) 📝 `Sources/OAuthSwiftHTTPRequest.swift` (+2 -2) 📝 `Sources/OAuthSwiftURLHandlerType.swift` (+1 -1) 📝 `Sources/OAuthWebViewController.swift` (+3 -3) 📝 `Sources/String+OAuthSwift.swift` (+6 -3) </details> ### 📄 Description Migrated to Swift 4 and Xcode 9. Tests succeeded when running locally, but best for someone to review. Fixes issue #409. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>