[PR #357] [MERGED] Making notification name public #609

New issue

Closed

opened 2026-03-03 16:49:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/357
Author: @hiragram
Created: 4/4/2017
Status: ✅ Merged
Merged: 4/4/2017
Merged by: @phimage

Base: master ← Head: master

📝 Commits (2)

3c5f739 Deprecate CallbackNotification.notificationName and move to extension of Notification.Name
28f0643 Fix message

📊 Changes

4 files changed (+28 additions, -4 deletions)

View changed files

📝 OAuthSwift.xcodeproj/project.pbxproj (+11 -1)
➕ Sources/NotificationCenter+OAuthSwift.swift (+13 -0)
📝 Sources/OAuthSwift.swift (+3 -2)
📝 Sources/OAuthSwiftURLHandlerType.swift (+1 -1)

📄 Description

This PR is related to #356 .

I wanted to receive callback for authorization process was finished in my custom OAuthSwiftURLHandlerType .
But CallbackNotification is internal struct so I cannot use from outside of module.

For more detail, see conversation in #356 .

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/357 **Author:** [@hiragram](https://github.com/hiragram) **Created:** 4/4/2017 **Status:** ✅ Merged **Merged:** 4/4/2017 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`3c5f739`](https://github.com/OAuthSwift/OAuthSwift/commit/3c5f7396b1fde1722a3dc7a1d503032516d28755) Deprecate CallbackNotification.notificationName and move to extension of Notification.Name - [`28f0643`](https://github.com/OAuthSwift/OAuthSwift/commit/28f0643fbd92f868dabfdd3cef23e325c7e5d0fd) Fix message ### 📊 Changes **4 files changed** (+28 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+11 -1) ➕ `Sources/NotificationCenter+OAuthSwift.swift` (+13 -0) 📝 `Sources/OAuthSwift.swift` (+3 -2) 📝 `Sources/OAuthSwiftURLHandlerType.swift` (+1 -1) </details> ### 📄 Description This PR is related to #356 . I wanted to receive callback for authorization process was finished in my custom `OAuthSwiftURLHandlerType` . But `CallbackNotification` is internal struct so I cannot use from outside of module. For more detail, see conversation in #356 . --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>