[PR #351] [MERGED] Created a variable that we can handle if want or not animation transition #607

New issue

Closed

opened 2026-03-03 16:49:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/351
Author: @felipeflorencio
Created: 3/14/2017
Status: ✅ Merged
Merged: 3/14/2017
Merged by: @phimage

Base: master ← Head: master

📝 Commits (1)

044fb1d Created a variable that we can handle to set for false if we do not want navigation transition animation

📊 Changes

1 file changed (+6 additions, -4 deletions)

View changed files

📝 Sources/OAuthWebViewController.swift (+6 -4)

📄 Description

I have the need to set to false navigation transition, because my type of navigation UX, but using the webview provided by lib i can not do this, only if i change the lib, but will cause problem beside i'm using cocoapods as manager.

So i changed the variable "animated" to one that now is public and provide by default the animation as "true", but now i have the chance to set to "false" if i need.

Hope get merged so i will can use at my project without need of change all the flow or something like that

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/351 **Author:** [@felipeflorencio](https://github.com/felipeflorencio) **Created:** 3/14/2017 **Status:** ✅ Merged **Merged:** 3/14/2017 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`044fb1d`](https://github.com/OAuthSwift/OAuthSwift/commit/044fb1d773c1b85f14cf2f5a5fca183f99a07baf) Created a variable that we can handle to set for false if we do not want navigation transition animation ### 📊 Changes **1 file changed** (+6 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `Sources/OAuthWebViewController.swift` (+6 -4) </details> ### 📄 Description I have the need to set to false navigation transition, because my type of navigation UX, but using the webview provided by lib i can not do this, only if i change the lib, but will cause problem beside i'm using cocoapods as manager. So i changed the variable "animated" to one that now is public and provide by default the animation as "true", but now i have the chance to set to "false" if i need. Hope get merged so i will can use at my project without need of change all the flow or something like that --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>