[PR #287] [MERGED] Fix multipart request with some parameters (master) #597

Closed
opened 2026-03-03 16:49:37 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/287
Author: @ktakayama
Created: 10/7/2016
Status: Merged
Merged: 10/7/2016
Merged by: @phimage

Base: masterHead: fix-multipart-with-parameter


📝 Commits (3)

  • 15cf127 Fix request.HTTPBody would be overridden by argument of parameters in postImage()
  • 7bd2120 Remove duplicate code and add test public method
  • e16d080 Add makeMultiPartRequest to remove duplicate code

📊 Changes

3 files changed (+69 additions, -39 deletions)

View changed files

📝 OAuthSwiftTests/OAuthSwiftClientTests.swift (+35 -0)
📝 Sources/OAuthSwiftClient.swift (+31 -39)
📝 Sources/OAuthSwiftHTTPRequest.swift (+3 -0)

📄 Description

same as #286


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/287 **Author:** [@ktakayama](https://github.com/ktakayama) **Created:** 10/7/2016 **Status:** ✅ Merged **Merged:** 10/7/2016 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `fix-multipart-with-parameter` --- ### 📝 Commits (3) - [`15cf127`](https://github.com/OAuthSwift/OAuthSwift/commit/15cf1270eef042e4bdcf3b8ed5b12379fb589f5f) Fix request.HTTPBody would be overridden by argument of parameters in postImage() - [`7bd2120`](https://github.com/OAuthSwift/OAuthSwift/commit/7bd2120e27884ef3d2c34af99f765eec24a8e54b) Remove duplicate code and add test public method - [`e16d080`](https://github.com/OAuthSwift/OAuthSwift/commit/e16d080dcc2a0d0c6311a1e9933b111850d1d282) Add makeMultiPartRequest to remove duplicate code ### 📊 Changes **3 files changed** (+69 additions, -39 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwiftTests/OAuthSwiftClientTests.swift` (+35 -0) 📝 `Sources/OAuthSwiftClient.swift` (+31 -39) 📝 `Sources/OAuthSwiftHTTPRequest.swift` (+3 -0) </details> ### 📄 Description same as #286 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 16:49:37 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#597
No description provided.