[PR #267] [CLOSED] [WIP] Compatibility with Swift 3.0 (up to Xcode 8 GM) #590

New issue

Closed

opened 2026-03-03 16:49:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/267
Author: @nighthawk
Created: 8/17/2016
Status: ❌ Closed

Base: swift3.0 ← Head: swift3.0

📝 Commits (10+)

453fbc8 Update OAuthSwift.podspec
a238d75 Update OAuthSwift.podspec
5421efb Update OAuthSwift.podspec
2679a12 Custom name of pod
6baaa42 Merge commit '2679a' into swift3.0
17f3f30 Swift 3 beta 5 fixes
72219e4 Use same name as main repo
41eb189 Swift 3 beta 5 fix
3e65c41 Xcode’s migration for beta 6
d3ddc83 Xcode 8 beta 6 fixes

📊 Changes

28 files changed (+451 additions, -422 deletions)

View changed files

📝 OAuthSwift.podspec (+1 -1)
📝 OAuthSwift.xcodeproj/project.pbxproj (+38 -25)
📝 OAuthSwift/Dictionary+OAuthSwift.swift (+2 -2)
📝 OAuthSwift/HMAC.swift (+2 -2)
📝 OAuthSwift/Int+OAuthSwift.swift (+6 -6)
📝 OAuthSwift/NSData+OAuthSwift.swift (+2 -2)
📝 OAuthSwift/NSURL+OAuthSwift.swift (+1 -5)
📝 OAuthSwift/OAuth1Swift.swift (+21 -23)
📝 OAuthSwift/OAuth2Swift.swift (+41 -41)
📝 OAuthSwift/OAuthSwift.swift (+14 -14)
📝 OAuthSwift/OAuthSwiftClient.swift (+22 -22)
📝 OAuthSwift/OAuthSwiftCredential.swift (+33 -33)
📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+48 -45)
📝 OAuthSwift/OAuthSwiftURLHandlerType.swift (+20 -20)
📝 OAuthSwift/OAuthWebViewController.swift (+9 -9)
📝 OAuthSwift/SHA1.swift (+2 -2)
📝 OAuthSwift/String+OAuthSwift.swift (+1 -1)
📝 OAuthSwift/UIApplication+OAuthSwift.swift (+5 -5)
📝 OAuthSwiftDemo/Services.swift (+6 -6)
📝 OAuthSwiftTests/OAuth1SwiftTests.swift (+14 -14)

...and 8 more files

📄 Description

This includes both changes suggested by Xcode's migration tool as well as manual fixing of the issues that Xcode couldn't migrate.

Action list:

Double-check Int+OAuthSwift.swift
Code review
Squash commits
Get tests to work again
Fix test failures

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/267 **Author:** [@nighthawk](https://github.com/nighthawk) **Created:** 8/17/2016 **Status:** ❌ Closed **Base:** `swift3.0` ← **Head:** `swift3.0` --- ### 📝 Commits (10+) - [`453fbc8`](https://github.com/OAuthSwift/OAuthSwift/commit/453fbc81491522ad9c195c13792844fdb0700382) Update OAuthSwift.podspec - [`a238d75`](https://github.com/OAuthSwift/OAuthSwift/commit/a238d7538215929d22f7f2975386636ca0a691c0) Update OAuthSwift.podspec - [`5421efb`](https://github.com/OAuthSwift/OAuthSwift/commit/5421efbb7cd975838743471e36a32020295fe4c2) Update OAuthSwift.podspec - [`2679a12`](https://github.com/OAuthSwift/OAuthSwift/commit/2679a1294ee8c2b489e0e998fe087141906d5507) Custom name of pod - [`6baaa42`](https://github.com/OAuthSwift/OAuthSwift/commit/6baaa42c368e6e2cd43c2501b2624f5bd4644091) Merge commit '2679a' into swift3.0 - [`17f3f30`](https://github.com/OAuthSwift/OAuthSwift/commit/17f3f306b80902a980fee97bb2faf320a9f2989c) Swift 3 beta 5 fixes - [`72219e4`](https://github.com/OAuthSwift/OAuthSwift/commit/72219e49ba969725ac6d08ffccb3e5d436ccd6ee) Use same name as main repo - [`41eb189`](https://github.com/OAuthSwift/OAuthSwift/commit/41eb1899e421c7f02a17c47c76c1f03a075785e0) Swift 3 beta 5 fix - [`3e65c41`](https://github.com/OAuthSwift/OAuthSwift/commit/3e65c41eeb810ba8934e95bbbcc9e4b13bc1eade) Xcode’s migration for beta 6 - [`d3ddc83`](https://github.com/OAuthSwift/OAuthSwift/commit/d3ddc8372a5c4e9d24e0cf3a5fdb48629c377c05) Xcode 8 beta 6 fixes ### 📊 Changes **28 files changed** (+451 additions, -422 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift.podspec` (+1 -1) 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+38 -25) 📝 `OAuthSwift/Dictionary+OAuthSwift.swift` (+2 -2) 📝 `OAuthSwift/HMAC.swift` (+2 -2) 📝 `OAuthSwift/Int+OAuthSwift.swift` (+6 -6) 📝 `OAuthSwift/NSData+OAuthSwift.swift` (+2 -2) 📝 `OAuthSwift/NSURL+OAuthSwift.swift` (+1 -5) 📝 `OAuthSwift/OAuth1Swift.swift` (+21 -23) 📝 `OAuthSwift/OAuth2Swift.swift` (+41 -41) 📝 `OAuthSwift/OAuthSwift.swift` (+14 -14) 📝 `OAuthSwift/OAuthSwiftClient.swift` (+22 -22) 📝 `OAuthSwift/OAuthSwiftCredential.swift` (+33 -33) 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+48 -45) 📝 `OAuthSwift/OAuthSwiftURLHandlerType.swift` (+20 -20) 📝 `OAuthSwift/OAuthWebViewController.swift` (+9 -9) 📝 `OAuthSwift/SHA1.swift` (+2 -2) 📝 `OAuthSwift/String+OAuthSwift.swift` (+1 -1) 📝 `OAuthSwift/UIApplication+OAuthSwift.swift` (+5 -5) 📝 `OAuthSwiftDemo/Services.swift` (+6 -6) 📝 `OAuthSwiftTests/OAuth1SwiftTests.swift` (+14 -14) _...and 8 more files_ </details> ### 📄 Description This includes both changes suggested by Xcode's migration tool as well as manual fixing of the issues that Xcode couldn't migrate. Action list: - [ ] Double-check `Int+OAuthSwift.swift` - [ ] Code review - [ ] Squash commits - [x] Get tests to work again - [x] Fix test failures --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>