[PR #277] [MERGED] Swift 3 and Xcode 8 fixes #588

New issue

Closed

opened 2026-03-03 16:49:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/277
Author: @nighthawk
Created: 9/23/2016
Status: ✅ Merged
Merged: 9/23/2016
Merged by: @phimage

Base: swift3.0 ← Head: swift3

📝 Commits (1)

a655462 Swift 3 and Xcode 8 fixes

📊 Changes

28 files changed (+451 additions, -422 deletions)

View changed files

📝 OAuthSwift.podspec (+1 -1)
📝 OAuthSwift.xcodeproj/project.pbxproj (+38 -25)
📝 OAuthSwift/Dictionary+OAuthSwift.swift (+2 -2)
📝 OAuthSwift/HMAC.swift (+2 -2)
📝 OAuthSwift/Int+OAuthSwift.swift (+6 -6)
📝 OAuthSwift/NSData+OAuthSwift.swift (+2 -2)
📝 OAuthSwift/NSURL+OAuthSwift.swift (+1 -5)
📝 OAuthSwift/OAuth1Swift.swift (+21 -23)
📝 OAuthSwift/OAuth2Swift.swift (+41 -41)
📝 OAuthSwift/OAuthSwift.swift (+14 -14)
📝 OAuthSwift/OAuthSwiftClient.swift (+22 -22)
📝 OAuthSwift/OAuthSwiftCredential.swift (+33 -33)
📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+48 -45)
📝 OAuthSwift/OAuthSwiftURLHandlerType.swift (+20 -20)
📝 OAuthSwift/OAuthWebViewController.swift (+9 -9)
📝 OAuthSwift/SHA1.swift (+2 -2)
📝 OAuthSwift/String+OAuthSwift.swift (+1 -1)
📝 OAuthSwift/UIApplication+OAuthSwift.swift (+5 -5)
📝 OAuthSwiftDemo/Services.swift (+6 -6)
📝 OAuthSwiftTests/OAuth1SwiftTests.swift (+14 -14)

...and 8 more files

📄 Description

Squashed version of #267: Compatibility with Swift 3.0 (up to Xcode 8 GM)

Action list:

Double-check Int+OAuthSwift.swift
Code review
Squash commits
Get tests to work again
Fix test failures

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/277 **Author:** [@nighthawk](https://github.com/nighthawk) **Created:** 9/23/2016 **Status:** ✅ Merged **Merged:** 9/23/2016 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `swift3.0` ← **Head:** `swift3` --- ### 📝 Commits (1) - [`a655462`](https://github.com/OAuthSwift/OAuthSwift/commit/a655462acd4b339dfea1ae95a31a195ba82d231b) Swift 3 and Xcode 8 fixes ### 📊 Changes **28 files changed** (+451 additions, -422 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift.podspec` (+1 -1) 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+38 -25) 📝 `OAuthSwift/Dictionary+OAuthSwift.swift` (+2 -2) 📝 `OAuthSwift/HMAC.swift` (+2 -2) 📝 `OAuthSwift/Int+OAuthSwift.swift` (+6 -6) 📝 `OAuthSwift/NSData+OAuthSwift.swift` (+2 -2) 📝 `OAuthSwift/NSURL+OAuthSwift.swift` (+1 -5) 📝 `OAuthSwift/OAuth1Swift.swift` (+21 -23) 📝 `OAuthSwift/OAuth2Swift.swift` (+41 -41) 📝 `OAuthSwift/OAuthSwift.swift` (+14 -14) 📝 `OAuthSwift/OAuthSwiftClient.swift` (+22 -22) 📝 `OAuthSwift/OAuthSwiftCredential.swift` (+33 -33) 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+48 -45) 📝 `OAuthSwift/OAuthSwiftURLHandlerType.swift` (+20 -20) 📝 `OAuthSwift/OAuthWebViewController.swift` (+9 -9) 📝 `OAuthSwift/SHA1.swift` (+2 -2) 📝 `OAuthSwift/String+OAuthSwift.swift` (+1 -1) 📝 `OAuthSwift/UIApplication+OAuthSwift.swift` (+5 -5) 📝 `OAuthSwiftDemo/Services.swift` (+6 -6) 📝 `OAuthSwiftTests/OAuth1SwiftTests.swift` (+14 -14) _...and 8 more files_ </details> ### 📄 Description Squashed version of #267: Compatibility with Swift 3.0 (up to Xcode 8 GM) Action list: - [ ] Double-check `Int+OAuthSwift.swift` - [ ] Code review - [x] Squash commits - [x] Get tests to work again - [x] Fix test failures --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>