[PR #218] [MERGED] Fix and improve unit tests #573

New issue

Closed

opened 2026-03-03 16:49:31 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/218
Author: @FGoessler
Created: 4/5/2016
Status: ✅ Merged
Merged: 4/6/2016
Merged by: @phimage

Base: master ← Head: #214-fix-and-improve-unit-tests

📝 Commits (5)

34e7975 #214 improved reliability of some unit tests
722d3d1 #214 fixed unit tests which failed because of missing state parameter
fb70a61 #214 fixed the nonce test by introducing a tolerance via XCTAssertEqualWithAccuracy
89580e7 #214 changed expected signature in unit test for now - see #115 for the related discussion
9ce0fc6 #214 added additional unit tests for the makeRequest method on OAuthSwiftClient

📊 Changes

8 files changed (+91 additions, -72 deletions)

View changed files

📝 OAuthSwift.xcodeproj/project.pbxproj (+4 -0)
📝 OAuthSwiftTests/OAuth1SwiftTests.swift (+1 -16)
📝 OAuthSwiftTests/OAuth2SwiftTests.swift (+10 -21)
📝 OAuthSwiftTests/OAuthSwiftClientTests.swift (+29 -27)
📝 OAuthSwiftTests/OAuthSwiftRequestTests.swift (+1 -1)
➕ OAuthSwiftTests/OAuthSwiftServerBaseTest.swift (+33 -0)
📝 OAuthSwiftTests/SignTests.swift (+8 -5)
📝 OAuthSwiftTests/TestOAuthSwiftURLHandler.swift (+5 -2)

📄 Description

This PR aims to fix and improve the unit tests as discussed in #214, although it does not address all issues mentioned there.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/218 **Author:** [@FGoessler](https://github.com/FGoessler) **Created:** 4/5/2016 **Status:** ✅ Merged **Merged:** 4/6/2016 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `#214-fix-and-improve-unit-tests` --- ### 📝 Commits (5) - [`34e7975`](https://github.com/OAuthSwift/OAuthSwift/commit/34e7975b1e63115c0c94923d7c194590c22f4263) #214 improved reliability of some unit tests - [`722d3d1`](https://github.com/OAuthSwift/OAuthSwift/commit/722d3d16048c5f4357428b8ab4ef5ac38aea7ce2) #214 fixed unit tests which failed because of missing state parameter - [`fb70a61`](https://github.com/OAuthSwift/OAuthSwift/commit/fb70a61603a78ca641ec5fbdebc46c9ad59c1510) #214 fixed the nonce test by introducing a tolerance via XCTAssertEqualWithAccuracy - [`89580e7`](https://github.com/OAuthSwift/OAuthSwift/commit/89580e7c92436fd911e694555d4238f43ebd9c34) #214 changed expected signature in unit test for now - see #115 for the related discussion - [`9ce0fc6`](https://github.com/OAuthSwift/OAuthSwift/commit/9ce0fc6d68cbb5e8fbfb972a310bff9b5df67b08) #214 added additional unit tests for the makeRequest method on OAuthSwiftClient ### 📊 Changes **8 files changed** (+91 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+4 -0) 📝 `OAuthSwiftTests/OAuth1SwiftTests.swift` (+1 -16) 📝 `OAuthSwiftTests/OAuth2SwiftTests.swift` (+10 -21) 📝 `OAuthSwiftTests/OAuthSwiftClientTests.swift` (+29 -27) 📝 `OAuthSwiftTests/OAuthSwiftRequestTests.swift` (+1 -1) ➕ `OAuthSwiftTests/OAuthSwiftServerBaseTest.swift` (+33 -0) 📝 `OAuthSwiftTests/SignTests.swift` (+8 -5) 📝 `OAuthSwiftTests/TestOAuthSwiftURLHandler.swift` (+5 -2) </details> ### 📄 Description This PR aims to fix and improve the unit tests as discussed in #214, although it does not address all issues mentioned there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>