[PR #213] [MERGED] Added cancel method on OAuthSwiftHTTPRequest #571

New issue

Closed

opened 2026-03-03 16:49:30 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/213
Author: @FGoessler
Created: 4/3/2016
Status: ✅ Merged
Merged: 4/3/2016
Merged by: @phimage

Base: master ← Head: #211-Provide-Cancel-Method

📝 Commits (1)

3d3a000 #211: Added a cancel method on OAuthSwiftHTTPRequest which uses the cancel method of NSURLSessionTask.

📊 Changes

2 files changed (+40 additions, -3 deletions)

View changed files

📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+7 -2)
📝 OAuthSwiftTests/OAuthSwiftRequestTests.swift (+33 -1)

📄 Description

With this pull request I implemented a cancel a method on OAuthSwiftHTTPRequest to allow clients to cancel request easily, as discussed in #211.

I also added a unit test for this new functionality but discovered that some other tests are failing on my machine - before my change as well as after my change and also for the last released version 0.5.1. I haven't fixed them because I don't know why they are broken and this is not related to this feature. Maybe some issue with Xcode 7.3? Haven't tried with older Xcode versions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/213 **Author:** [@FGoessler](https://github.com/FGoessler) **Created:** 4/3/2016 **Status:** ✅ Merged **Merged:** 4/3/2016 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `#211-Provide-Cancel-Method` --- ### 📝 Commits (1) - [`3d3a000`](https://github.com/OAuthSwift/OAuthSwift/commit/3d3a000cf5b2e89ac9e4a81973f12961f18d4174) #211: Added a cancel method on OAuthSwiftHTTPRequest which uses the cancel method of NSURLSessionTask. ### 📊 Changes **2 files changed** (+40 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+7 -2) 📝 `OAuthSwiftTests/OAuthSwiftRequestTests.swift` (+33 -1) </details> ### 📄 Description With this pull request I implemented a cancel a method on OAuthSwiftHTTPRequest to allow clients to cancel request easily, as discussed in #211. I also added a unit test for this new functionality but discovered that some other tests are failing on my machine - before my change as well as after my change and also for the last released version 0.5.1. I haven't fixed them because I don't know why they are broken and this is not related to this feature. Maybe some issue with Xcode 7.3? Haven't tried with older Xcode versions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>