[PR #201] [MERGED] Fixed the encoding to comply with the OAuth 1.0 specification #564

New issue

Closed

opened 2026-03-03 16:49:28 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/201
Author: @dbmrq
Created: 3/9/2016
Status: ✅ Merged
Merged: 3/9/2016
Merged by: @phimage

Base: master ← Head: encodingFix

📝 Commits (1)

c044bd4 Fixed the encoding to comply with the OAuth 1.0 specification

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 OAuthSwift/String+OAuthSwift.swift (+1 -1)

📄 Description

The OAuth 1.0 specification is very clear about what is allowed:

Characters in the unreserved character set as defined by [RFC3986],
Section 2.3 (ALPHA, DIGIT, "-", ".", "_", "~") MUST NOT be encoded.

All other characters MUST be encoded.
(https://tools.ietf.org/html/rfc5849)

I modified the code to better reflect that.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/201 **Author:** [@dbmrq](https://github.com/dbmrq) **Created:** 3/9/2016 **Status:** ✅ Merged **Merged:** 3/9/2016 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `encodingFix` --- ### 📝 Commits (1) - [`c044bd4`](https://github.com/OAuthSwift/OAuthSwift/commit/c044bd4b506977b87670d961cfce52676544b430) Fixed the encoding to comply with the OAuth 1.0 specification ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/String+OAuthSwift.swift` (+1 -1) </details> ### 📄 Description The OAuth 1.0 specification is very clear about what is allowed: > - Characters in the unreserved character set as defined by [RFC3986], > Section 2.3 (ALPHA, DIGIT, "-", ".", "_", "~") MUST NOT be encoded. > - All other characters MUST be encoded. > (https://tools.ietf.org/html/rfc5849) I modified the code to better reflect that. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>