[PR #188] [MERGED] Add an option to send the OAuth1.0 parameters as request parameters (fix #187) #554

New issue

Closed

opened 2026-03-03 16:49:25 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/188
Author: @jdrevet
Created: 2/20/2016
Status: ✅ Merged
Merged: 2/21/2016
Merged by: @phimage

Base: master ← Head: OAuth1ParamsTransmission

📝 Commits (3)

ce1f82b Add an option to send the OAuth1.0 parameters as request parameters (fix #187)
b9838d1 Revert changes in OAuth1Swift after PR comment
ffd0f5a Remove the '?' operators for paramsLocation parameter as discussed in PR comment

📊 Changes

4 files changed (+76 additions, -27 deletions)

View changed files

📝 OAuthSwift/OAuthSwiftClient.swift (+12 -3)
📝 OAuthSwift/OAuthSwiftCredential.swift (+23 -13)
📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+29 -11)
📝 OAuthSwiftDemo/ViewController.swift (+12 -0)

📄 Description

As described in issue #187, some servers (at least the Withings one) require that the OAuth1.0 parameters are transmitted as query parameters.

As it is not an usual behaviour, I have tried to minimize the changes by using convenience initializers and optionnals parameters with default value.

There is 2 places where the process differs:

In OAuthSwiftClient where the oauth parameters are set in the authorization header or in query paremeters
In OAuthSwiftHTTPRequest where the oauth parameters should not be removed from the query parameters in the new case

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/188 **Author:** [@jdrevet](https://github.com/jdrevet) **Created:** 2/20/2016 **Status:** ✅ Merged **Merged:** 2/21/2016 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `OAuth1ParamsTransmission` --- ### 📝 Commits (3) - [`ce1f82b`](https://github.com/OAuthSwift/OAuthSwift/commit/ce1f82bf8d6aee6003720ad901831dd4090a3cbc) Add an option to send the OAuth1.0 parameters as request parameters (fix #187) - [`b9838d1`](https://github.com/OAuthSwift/OAuthSwift/commit/b9838d16b1949ff451e2d393595d221a77fd23f0) Revert changes in OAuth1Swift after PR comment - [`ffd0f5a`](https://github.com/OAuthSwift/OAuthSwift/commit/ffd0f5a2a26913105920f191b1689700b183f783) Remove the '?' operators for paramsLocation parameter as discussed in PR comment ### 📊 Changes **4 files changed** (+76 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuthSwiftClient.swift` (+12 -3) 📝 `OAuthSwift/OAuthSwiftCredential.swift` (+23 -13) 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+29 -11) 📝 `OAuthSwiftDemo/ViewController.swift` (+12 -0) </details> ### 📄 Description As described in issue #187, some servers (at least the Withings one) require that the OAuth1.0 parameters are transmitted as query parameters. As it is not an usual behaviour, I have tried to minimize the changes by using convenience initializers and optionnals parameters with default value. There is 2 places where the process differs: - In OAuthSwiftClient where the oauth parameters are set in the authorization header or in query paremeters - In OAuthSwiftHTTPRequest where the oauth parameters should not be removed from the query parameters in the new case --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>