[PR #169] [CLOSED] Allow for invalidating notification observers on OAuthSwift objects #546

New issue

Closed

opened 2026-03-03 16:49:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/169
Author: @ghost
Created: 1/8/2016
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (2)

fdbbc62 Added support for invalidating existing requests in case something goes wrong
cc090f8 Fix compile error due to unwrapped optional

📊 Changes

1 file changed (+8 additions, -0 deletions)

View changed files

📝 OAuthSwift/OAuthSwift.swift (+8 -0)

📄 Description

Currently in OAuthSwift it doesn't seem to be possible to retry an OAuth connection. If you attempt to use a brand new OAuthSwift object, the old notifications still fire as there's no way to clean them up.

This addition enables these notification observers to be cleaned up from the old OAuth object before attempting to use another one.

I'd welcome any other suggestions if this is not ideal, or if there's another way to completely retry an OAuth connection without any existing data from the last connection attempt making its way through.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/169 **Author:** [@ghost](https://github.com/ghost) **Created:** 1/8/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`fdbbc62`](https://github.com/OAuthSwift/OAuthSwift/commit/fdbbc622472fb858f4a0939c25a0159dfb908f11) Added support for invalidating existing requests in case something goes wrong - [`cc090f8`](https://github.com/OAuthSwift/OAuthSwift/commit/cc090f82eae53549f49ca1fce7534a18db97f268) Fix compile error due to unwrapped optional ### 📊 Changes **1 file changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuthSwift.swift` (+8 -0) </details> ### 📄 Description Currently in OAuthSwift it doesn't seem to be possible to retry an OAuth connection. If you attempt to use a brand new OAuthSwift object, the old notifications still fire as there's no way to clean them up. This addition enables these notification observers to be cleaned up from the old OAuth object before attempting to use another one. I'd welcome any other suggestions if this is not ideal, or if there's another way to completely retry an OAuth connection without any existing data from the last connection attempt making its way through. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>