[PR #165] [CLOSED] fix urlEncodedStringWithEncoding to remove reserved characters #544

New issue

Closed

opened 2026-03-03 16:49:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/165
Author: @tkawaji
Created: 12/26/2015
Status: ❌ Closed

Base: master ← Head: fix_urlencode_rfc3986

📝 Commits (1)

01d29c0 fix urlEncodedStringWithEncoding to remove reserved characters

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 OAuthSwift/String+OAuthSwift.swift (+5 -1)

📄 Description

There is signiture error when parameter value includes line feed code(\n).
So I basically use NSCharacterSet.URLQueryAllowedCharacterSet for stringByAddingPercentEncodingWithAllowedCharacters.
And remove some characters defined as reserved in RFC 3986.

I think there are big changes in urlencoding behavior from existing source code.
So I would appreciate if you could check carefully.

Thank you.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/165 **Author:** [@tkawaji](https://github.com/tkawaji) **Created:** 12/26/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix_urlencode_rfc3986` --- ### 📝 Commits (1) - [`01d29c0`](https://github.com/OAuthSwift/OAuthSwift/commit/01d29c0827d835789303133cd2dd0af754ee3f25) fix urlEncodedStringWithEncoding to remove reserved characters ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/String+OAuthSwift.swift` (+5 -1) </details> ### 📄 Description There is signiture error when parameter value includes line feed code(\n). So I basically use NSCharacterSet.URLQueryAllowedCharacterSet for stringByAddingPercentEncodingWithAllowedCharacters. And remove some characters defined as reserved in RFC 3986. I think there are big changes in urlencoding behavior from existing source code. So I would appreciate if you could check carefully. Thank you. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>