[PR #168] [CLOSED] URL-Encode square brackets Fix #174 #543

New issue

Closed

opened 2026-03-03 16:49:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/168
Author: @nighthawk
Created: 1/1/2016
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (1)

abe9cdf Update String+OAuthSwift.swift

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 OAuthSwift/String+OAuthSwift.swift (+1 -1)

📄 Description

I've hit an issue where the OAuth signature was calculated wrongly, which I traced back to some of the parameters of the API that I'm using (UserVoice) having parameters such as object[field]=value and OAuthSwift didn't escape the square brackets.

I checked this against the nouncer.com calculator. With my fix, the signature from OAuthSwift matches that, and it's also matching the API that I'm connecting to.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/168 **Author:** [@nighthawk](https://github.com/nighthawk) **Created:** 1/1/2016 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`abe9cdf`](https://github.com/OAuthSwift/OAuthSwift/commit/abe9cdf3943bf28e8ff5cefeeaa2cab3167eccda) Update String+OAuthSwift.swift ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/String+OAuthSwift.swift` (+1 -1) </details> ### 📄 Description I've hit an issue where the OAuth signature was calculated wrongly, which I traced back to some of the parameters of the API that I'm using ([UserVoice](https://developer.uservoice.com/docs/api/reference/)) having parameters such as `object[field]=value` and OAuthSwift didn't escape the square brackets. I checked this against [the nouncer.com calculator](http://nouncer.com/oauth/signature.html). With my fix, the signature from OAuthSwift matches that, and it's also matching the API that I'm connecting to. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>