[PR #153] [MERGED] SafariURLHandler: missing "public" access for externally configurable variables #537

New issue

Closed

opened 2026-03-03 16:49:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/153
Author: @almostintuitive
Created: 12/1/2015
Status: ✅ Merged
Merged: 12/1/2015
Merged by: @phimage

Base: master ← Head: safariurlhandler-delegate-public-access

📝 Commits (1)

b8faedc fix(safari-url-handler): added "public" to various externally configurable variables

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 OAuthSwift/OAuthSwiftURLHandlerType.swift (+4 -4)

📄 Description

Hi,

Thanks for the great work of making this happen - it helped us not to reinvent the wheel big time!

I came across the issue where the following variables on SafariURLHandler weren't accessible from outside of the framework (missing public annotiation):

    var animated: Bool = true
    var delegate: SFSafariViewControllerDelegate?
    var presentCompletion: (() -> Void)?
    var dismissCompletion: (() -> Void)?

Since I needed to customise the behaviour of this class I needed to set these - and at the same time I thought these were probably intended to be externally configurable originally. (otherwise these are not used inside the framework, so there's no point of their existence:)

Cheers,

Mark

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/153 **Author:** [@almostintuitive](https://github.com/almostintuitive) **Created:** 12/1/2015 **Status:** ✅ Merged **Merged:** 12/1/2015 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `safariurlhandler-delegate-public-access` --- ### 📝 Commits (1) - [`b8faedc`](https://github.com/OAuthSwift/OAuthSwift/commit/b8faedcb8044b821f6231e28bc7c1e9b88be66fd) fix(safari-url-handler): added "public" to various externally configurable variables ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuthSwiftURLHandlerType.swift` (+4 -4) </details> ### 📄 Description Hi, Thanks for the great work of making this happen - it helped us not to reinvent the wheel big time! I came across the issue where the following variables on SafariURLHandler weren't accessible from outside of the framework (missing public annotiation): ``` var animated: Bool = true var delegate: SFSafariViewControllerDelegate? var presentCompletion: (() -> Void)? var dismissCompletion: (() -> Void)? ``` Since I needed to customise the behaviour of this class I needed to set these - and at the same time I thought these were probably intended to be externally configurable originally. (otherwise these are not used inside the framework, so there's no point of their existence:) Cheers, Mark --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>