[PR #143] [MERGED] Fix #129 by adding OAUTH_APP_EXTENSIONS setting var #532

New issue

Closed

opened 2026-03-03 16:49:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/143
Author: @phimage
Created: 11/9/2015
Status: ✅ Merged
Merged: 11/10/2015
Merged by: @phimage

Base: master ← Head: fix-129-extension

📝 Commits (2)

ac01000 Fix #129 by adding OAUTH_APP_EXTENSIONS setting var
1a996b2 Fix #129 by adding OAUTH_APP_EXTENSIONS setting var

📊 Changes

3 files changed (+27 additions, -5 deletions)

View changed files

📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+6 -2)
📝 OAuthSwift/OAuthSwiftURLHandlerType.swift (+17 -1)
📝 OAuthSwift/OAuthWebViewController.swift (+4 -2)

📄 Description

to disable access to UIApplication.sharedApplication() into iOS app extension
Add also an url handler based on NSExtensionContext

The fix is inspired from AFNetworking fix https://github.com/AFNetworking/AFNetworking/issues/2119
The use need to use post_install into Podfile to inject setting into its extension target
https://guides.cocoapods.org/syntax/podfile.html#post_install

config.build_settings['OAUTH_APP_EXTENSIONS'] = '1'

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/143 **Author:** [@phimage](https://github.com/phimage) **Created:** 11/9/2015 **Status:** ✅ Merged **Merged:** 11/10/2015 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `fix-129-extension` --- ### 📝 Commits (2) - [`ac01000`](https://github.com/OAuthSwift/OAuthSwift/commit/ac01000cdb1be6a0922dd7b5684b48680ad55989) Fix #129 by adding OAUTH_APP_EXTENSIONS setting var - [`1a996b2`](https://github.com/OAuthSwift/OAuthSwift/commit/1a996b219aa5520f37b0f3a2478b8ee7442b59c7) Fix #129 by adding OAUTH_APP_EXTENSIONS setting var ### 📊 Changes **3 files changed** (+27 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+6 -2) 📝 `OAuthSwift/OAuthSwiftURLHandlerType.swift` (+17 -1) 📝 `OAuthSwift/OAuthWebViewController.swift` (+4 -2) </details> ### 📄 Description to disable access to UIApplication.sharedApplication() into iOS app extension Add also an url handler based on NSExtensionContext The fix is inspired from AFNetworking fix https://github.com/AFNetworking/AFNetworking/issues/2119 The use need to use `post_install` into Podfile to inject setting into its extension target https://guides.cocoapods.org/syntax/podfile.html#post_install ``` config.build_settings['OAUTH_APP_EXTENSIONS'] = '1' ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>