[PR #141] [MERGED] Closes Issue #140 and #142. #531

New issue

Closed

opened 2026-03-03 16:49:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/141
Author: @pculligan
Created: 11/9/2015
Status: ✅ Merged
Merged: 11/12/2015
Merged by: @phimage

Base: master ← Head: master

📝 Commits (3)

121150f Closes Issue #140
cc193b1 Closes Issue #142. Adds handling for querystring parameters for OAuth1.0a
f25b08a Merge branch 'master' of https://github.com/dongri/OAuthSwift

📊 Changes

2 files changed (+42 additions, -6 deletions)

View changed files

📝 OAuthSwift/OAuth1Swift.swift (+12 -4)
📝 OAuthSwift/OAuthSwiftClient.swift (+30 -2)

📄 Description

Added decoding the URL-encoded oauth_token_secret to the OAuth1 flow (in Step 1 and Step 3) so that it would complete. Previous escaped values were preventing proper OAuth signatures.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/141 **Author:** [@pculligan](https://github.com/pculligan) **Created:** 11/9/2015 **Status:** ✅ Merged **Merged:** 11/12/2015 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`121150f`](https://github.com/OAuthSwift/OAuthSwift/commit/121150fb78bdb90dc44c4417736732c89ca5eddc) Closes Issue #140 - [`cc193b1`](https://github.com/OAuthSwift/OAuthSwift/commit/cc193b1bb9db30a8a37c68aaba77811dfd8c1108) Closes Issue #142. Adds handling for querystring parameters for OAuth1.0a - [`f25b08a`](https://github.com/OAuthSwift/OAuthSwift/commit/f25b08a03b150c017fb6b750f5deb39b30d1d027) Merge branch 'master' of https://github.com/dongri/OAuthSwift ### 📊 Changes **2 files changed** (+42 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuth1Swift.swift` (+12 -4) 📝 `OAuthSwift/OAuthSwiftClient.swift` (+30 -2) </details> ### 📄 Description Added decoding the URL-encoded `oauth_token_secret` to the OAuth1 flow (in Step 1 and Step 3) so that it would complete. Previous escaped values were preventing proper OAuth signatures. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>