[PR #132] [MERGED] Added protections on network timeout.. force unwrapping of 'data' was… #530

New issue

Closed

opened 2026-03-03 16:49:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/132
Author: @mikeMTOL
Created: 10/26/2015
Status: ✅ Merged
Merged: 11/10/2015
Merged by: @phimage

Base: master ← Head: master

📝 Commits (4)

f88342a Added protections on network timeout.. force unwrapping of 'data' was causing a unwrap of nil object crash..
ad1b480 fixed guard error
ddd0c22 more guard fixes
be06937 broke off NSError check

📊 Changes

1 file changed (+17 additions, -3 deletions)

View changed files

📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+17 -3)

📄 Description

… causing a unwrap of nil object crash..
blocks should not refer to 'self' directly and must use an unowned reference to self (memory leaks happen if not)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/132 **Author:** [@mikeMTOL](https://github.com/mikeMTOL) **Created:** 10/26/2015 **Status:** ✅ Merged **Merged:** 11/10/2015 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`f88342a`](https://github.com/OAuthSwift/OAuthSwift/commit/f88342a27995580d080a7e31c400e949b6e6f313) Added protections on network timeout.. force unwrapping of 'data' was causing a unwrap of nil object crash.. - [`ad1b480`](https://github.com/OAuthSwift/OAuthSwift/commit/ad1b480d09530d387ee5eafc97665f93548c10f9) fixed guard error - [`ddd0c22`](https://github.com/OAuthSwift/OAuthSwift/commit/ddd0c22cc84f300fa02845a03110b9b46f4cc42e) more guard fixes - [`be06937`](https://github.com/OAuthSwift/OAuthSwift/commit/be06937555a5999e51f890ce97e06f1a81386d7e) broke off NSError check ### 📊 Changes **1 file changed** (+17 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+17 -3) </details> ### 📄 Description … causing a unwrap of nil object crash.. blocks should not refer to 'self' directly and must use an unowned reference to self (memory leaks happen if not) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>