[PR #121] [MERGED] Add enum for HTTP Method and OAuth protocol version #523

New issue

Closed

opened 2026-03-03 16:49:16 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/121
Author: @phimage
Created: 10/7/2015
Status: ✅ Merged
Merged: 11/10/2015
Merged by: @phimage

Base: master ← Head: feature-enum

📝 Commits (1)

5e9ab5f Add enum for HTTP Method and for OAuth protocol version

📊 Changes

5 files changed (+50 additions, -38 deletions)

View changed files

📝 OAuthSwift/OAuth1Swift.swift (+3 -5)
📝 OAuthSwift/OAuth2Swift.swift (+4 -6)
📝 OAuthSwift/OAuthSwiftClient.swift (+11 -11)
📝 OAuthSwift/OAuthSwiftCredential.swift (+22 -10)
📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+10 -6)

📄 Description

2 enum created instead of using string

HTTP Method for request
protocol version for credential (or other things)

protocol version into credential is initialised in init of OAuthXXX class, I don't see any reason to postpone that, but maybe I am wrong

and remove useless re-call of success callback with all param, just pass the callback

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/121 **Author:** [@phimage](https://github.com/phimage) **Created:** 10/7/2015 **Status:** ✅ Merged **Merged:** 11/10/2015 **Merged by:** [@phimage](https://github.com/phimage) **Base:** `master` ← **Head:** `feature-enum` --- ### 📝 Commits (1) - [`5e9ab5f`](https://github.com/OAuthSwift/OAuthSwift/commit/5e9ab5f422ed6d8abb9bb3923422ff0ea3670e3a) Add enum for HTTP Method and for OAuth protocol version ### 📊 Changes **5 files changed** (+50 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuth1Swift.swift` (+3 -5) 📝 `OAuthSwift/OAuth2Swift.swift` (+4 -6) 📝 `OAuthSwift/OAuthSwiftClient.swift` (+11 -11) 📝 `OAuthSwift/OAuthSwiftCredential.swift` (+22 -10) 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+10 -6) </details> ### 📄 Description 2 enum created instead of using string - HTTP Method for request - protocol version for credential (or other things) protocol version into credential is initialised in `init` of `OAuthXXX` class, I don't see any reason to postpone that, but maybe I am wrong and remove useless re-call of success callback with all param, just pass the callback --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>