[PR #111] [MERGED] FIX #110 merge query and fragment parameters instead of choosing one #519

Closed
opened 2026-03-03 16:49:14 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/111
Author: @phimage
Created: 9/24/2015
Status: Merged
Merged: 9/25/2015
Merged by: @dongri

Base: masterHead: fix-queryandfragment


📝 Commits (1)

  • 2ce2728 FIX #110 merge query and fragment parameters instead of choosing one

📊 Changes

3 files changed (+19 additions, -5 deletions)

View changed files

📝 OAuthSwift/OAuth1Swift.swift (+4 -3)
📝 OAuthSwift/OAuth2Swift.swift (+2 -2)
📝 OAuthSwift/Utils.swift (+13 -0)

📄 Description

in oauth1 the elseis removed like in oauth2

and parameters dictionary are merged for the two versions

see my comment in issue #110, there is another fix


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/111 **Author:** [@phimage](https://github.com/phimage) **Created:** 9/24/2015 **Status:** ✅ Merged **Merged:** 9/25/2015 **Merged by:** [@dongri](https://github.com/dongri) **Base:** `master` ← **Head:** `fix-queryandfragment` --- ### 📝 Commits (1) - [`2ce2728`](https://github.com/OAuthSwift/OAuthSwift/commit/2ce2728faabbaf0653e4b0f47f5330e4b55044c8) FIX #110 merge query and fragment parameters instead of choosing one ### 📊 Changes **3 files changed** (+19 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/OAuth1Swift.swift` (+4 -3) 📝 `OAuthSwift/OAuth2Swift.swift` (+2 -2) 📝 `OAuthSwift/Utils.swift` (+13 -0) </details> ### 📄 Description in oauth1 the `else`is removed like in oauth2 and parameters dictionary are merged for the two versions see my comment in issue #110, there is another fix --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 16:49:14 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/OAuthSwift#519
No description provided.