[PR #64] [CLOSED] Factorize code from OAuth1Swift & OAuth2Swift to new file OAuthSwift #499

New issue

Closed

opened 2026-03-03 16:49:08 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/64
Author: @phimage
Created: 5/12/2015
Status: ❌ Closed

Base: master ← Head: master

📝 Commits (3)

a508732 Factorize code from OAuth1Swift & OAuth2Swift to new file OAuthSwift
3ece77d Merge pull request #1 from dongri/master
a330951 Merge remote-tracking branch 'upstream/master'

📊 Changes

9 files changed (+89 additions, -109 deletions)

View changed files

📝 OAuthSwift.xcodeproj/project.pbxproj (+6 -0)
📝 OAuthSwift/OAuth1Swift.swift (+8 -42)
📝 OAuthSwift/OAuth2Swift.swift (+4 -33)
➕ OAuthSwift/OAuthSwift.swift (+50 -0)
📝 OAuthSwift/OAuthSwiftClient.swift (+3 -3)
📝 OAuthSwiftDemo/AppDelegate.swift (+2 -8)
📝 OAuthSwiftOSXDemo/AppDelegate.swift (+13 -16)
📝 OAuthSwiftOSXDemo/WebViewController.swift (+2 -1)
📝 README.md (+1 -6)

📄 Description

... in consequence handleOpenURL() are now unique

Fix #26 by making credential getter public
(They want to load from saved application data the credential token and set it)
maybe credential could be set also if we want to use nscoder (by removing the added code private(set) )

set public the oauth1 last method to allow override

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/64 **Author:** [@phimage](https://github.com/phimage) **Created:** 5/12/2015 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`a508732`](https://github.com/OAuthSwift/OAuthSwift/commit/a5087322c26a8413e9a709e86711f29eec0572ff) Factorize code from OAuth1Swift & OAuth2Swift to new file OAuthSwift - [`3ece77d`](https://github.com/OAuthSwift/OAuthSwift/commit/3ece77d67457f34a4e0b4fc77bed5fc3f0ac1116) Merge pull request #1 from dongri/master - [`a330951`](https://github.com/OAuthSwift/OAuthSwift/commit/a33095137c5503337f5e311f501015f64b1a9a16) Merge remote-tracking branch 'upstream/master' ### 📊 Changes **9 files changed** (+89 additions, -109 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift.xcodeproj/project.pbxproj` (+6 -0) 📝 `OAuthSwift/OAuth1Swift.swift` (+8 -42) 📝 `OAuthSwift/OAuth2Swift.swift` (+4 -33) ➕ `OAuthSwift/OAuthSwift.swift` (+50 -0) 📝 `OAuthSwift/OAuthSwiftClient.swift` (+3 -3) 📝 `OAuthSwiftDemo/AppDelegate.swift` (+2 -8) 📝 `OAuthSwiftOSXDemo/AppDelegate.swift` (+13 -16) 📝 `OAuthSwiftOSXDemo/WebViewController.swift` (+2 -1) 📝 `README.md` (+1 -6) </details> ### 📄 Description ... in consequence handleOpenURL() are now unique Fix #26 by making credential getter public (They want to load from saved application data the credential token and set it) maybe credential could be set also if we want to use nscoder (by removing the added code private(set) ) set public the oauth1 last method to allow override --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>