[PR #30] [MERGED] Improve use of protocol #490

New issue

Closed

opened 2026-03-03 16:49:05 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:49:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/OAuthSwift/OAuthSwift/pull/30
Author: @rvangraan
Created: 3/3/2015
Status: ✅ Merged
Merged: 3/4/2015
Merged by: @dongri

Base: master ← Head: improve-use-of-protocol

📝 Commits (3)

a462bbf Support for Swift 1.2
debc7a4 (#22) Refactor OAuthSwiftHTTPRequest to support returning an NSURLRequest
8755293 Fix use of protocol so that any controller can be used

📊 Changes

13 files changed (+131 additions, -105 deletions)

View changed files

📝 OAuthSwift/HMAC.swift (+4 -4)
📝 OAuthSwift/Int+OAuthSwift.swift (+4 -4)
📝 OAuthSwift/NSData+OAuthSwift.swift (+6 -6)
📝 OAuthSwift/NSURL+OAuthSwift.swift (+2 -2)
📝 OAuthSwift/OAuth1Swift.swift (+9 -7)
📝 OAuthSwift/OAuth2Swift.swift (+10 -7)
📝 OAuthSwift/OAuthSwiftClient.swift (+9 -9)
📝 OAuthSwift/OAuthSwiftCredential.swift (+7 -7)
📝 OAuthSwift/OAuthSwiftHTTPRequest.swift (+67 -47)
📝 OAuthSwift/SHA1.swift (+1 -1)
📝 OAuthSwift/String+OAuthSwift.swift (+5 -5)
📝 OAuthSwiftDemo/AppDelegate.swift (+4 -3)
📝 OAuthSwiftDemo/WebViewController.swift (+3 -3)

📄 Description

Changed the implementation to that projects are not forced to inherit from OAuthWebViewController

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/OAuthSwift/OAuthSwift/pull/30 **Author:** [@rvangraan](https://github.com/rvangraan) **Created:** 3/3/2015 **Status:** ✅ Merged **Merged:** 3/4/2015 **Merged by:** [@dongri](https://github.com/dongri) **Base:** `master` ← **Head:** `improve-use-of-protocol` --- ### 📝 Commits (3) - [`a462bbf`](https://github.com/OAuthSwift/OAuthSwift/commit/a462bbfd0fb5b72e00191d8202035b6d6a62f493) Support for Swift 1.2 - [`debc7a4`](https://github.com/OAuthSwift/OAuthSwift/commit/debc7a4db3eee52a2edb1707b094887f2a2164fa) (#22) Refactor OAuthSwiftHTTPRequest to support returning an NSURLRequest - [`8755293`](https://github.com/OAuthSwift/OAuthSwift/commit/87552938a17125bf47c756ad0e7226c6de6e0a8c) Fix use of protocol so that any controller can be used ### 📊 Changes **13 files changed** (+131 additions, -105 deletions) <details> <summary>View changed files</summary> 📝 `OAuthSwift/HMAC.swift` (+4 -4) 📝 `OAuthSwift/Int+OAuthSwift.swift` (+4 -4) 📝 `OAuthSwift/NSData+OAuthSwift.swift` (+6 -6) 📝 `OAuthSwift/NSURL+OAuthSwift.swift` (+2 -2) 📝 `OAuthSwift/OAuth1Swift.swift` (+9 -7) 📝 `OAuthSwift/OAuth2Swift.swift` (+10 -7) 📝 `OAuthSwift/OAuthSwiftClient.swift` (+9 -9) 📝 `OAuthSwift/OAuthSwiftCredential.swift` (+7 -7) 📝 `OAuthSwift/OAuthSwiftHTTPRequest.swift` (+67 -47) 📝 `OAuthSwift/SHA1.swift` (+1 -1) 📝 `OAuthSwift/String+OAuthSwift.swift` (+5 -5) 📝 `OAuthSwiftDemo/AppDelegate.swift` (+4 -3) 📝 `OAuthSwiftDemo/WebViewController.swift` (+3 -3) </details> ### 📄 Description Changed the implementation to that projects are not forced to inherit from OAuthWebViewController --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>